jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prototype: Added support for multiple host in mock (#3762)

Browse Source 
Summary:
Apps usually communicate with multiple hosts to support pops and data centres. The problem currently is that for each host we need a different config in the mock tab in flipper. If the host change due to failover then the mocking stops working. Added support to enter the URL without a host in the flipper. We then check if the Url from the actual network request contains the mock URL without a host.

We can change the hint on flipper UI to suggest either entering the complete URL or without the host to allow matching across multiple hosts.

Resolve:[3751](https://github.com/facebook/flipper/issues/3751)

Let me know if the approach looks good.

## Changelog

Pull Request resolved: https://github.com/facebook/flipper/pull/3762

Reviewed By: lblasa

Differential Revision: D36780307

Pulled By: passy

fbshipit-source-id: 744898fa24d13343132e9a2165750241861245bd
This commit is contained in:
Harshit Bangar
2022-06-06 12:40:55 -07:00
committed by Facebook GitHub Bot
parent b7977a954a
commit c88e769013
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
android/plugins/network/src/main/java/com/facebook/flipper/plugins/network/FlipperOkhttpInterceptor.java
View File

@@ -23,6 +23,7 @@ import java.util.ArrayList;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Objects;
import java.util.Set; import java.util.Set;
import java.util.UUID; import java.util.UUID;
import javax.annotation.Nullable; import javax.annotation.Nullable;
@@ -192,10 +193,7 @@ public class FlipperOkhttpInterceptor
final String method = request.method(); final String method = request.method();
final PartialRequestInfo partialRequest = new PartialRequestInfo(url, method); final PartialRequestInfo partialRequest = new PartialRequestInfo(url, method);
if (!mMockResponseMap.containsKey(partialRequest)) { ResponseInfo mockResponse = getMockResponse(partialRequest);
return null;
}
ResponseInfo mockResponse = mMockResponseMap.get(partialRequest);
if (mockResponse == null) { if (mockResponse == null) {
return null; return null;
} }
@@ -219,6 +217,17 @@ public class FlipperOkhttpInterceptor
return builder.build(); return builder.build();
} }
private ResponseInfo getMockResponse(PartialRequestInfo partialRequestInfo) {
for (Map.Entry<PartialRequestInfo, ResponseInfo> entry : mMockResponseMap.entrySet()) {
PartialRequestInfo mockRequestInfo = entry.getKey();
if (partialRequestInfo.first.contains(mockRequestInfo.first)
&& Objects.equals(partialRequestInfo.second, mockRequestInfo.second)) {
return entry.getValue();
}
}
return null;
}
@Nullable @Nullable
private ResponseInfo convertFlipperObjectRouteToResponseInfo(FlipperObject route) { private ResponseInfo convertFlipperObjectRouteToResponseInfo(FlipperObject route) {
final String data = route.getString("data"); final String data = route.getString("data");