From c7f7ac0228ade0d075a340c18a26d76f77587329 Mon Sep 17 00:00:00 2001 From: Madeline Cripps Date: Tue, 9 Jun 2020 09:16:19 -0700 Subject: [PATCH] Migrate to FBSystrace Server Summary: As title, this restores all of the functionality of the original plugin to but uses json-rpc to interact with fbsystrace in server mode. Mostly at feature parity with the old plugins, need to update the following in my next diff: - Better fbsystrace error surfacing - Pipe all all output to 'Console' - Support non-select type options {F239554690} I think that the authentication issues with Tracery might go away in prod - according to https://fb.workplace.com/groups/flippersupport/permalink/889080114905981/ this seems like a dev issue. But the "Open in Browser" functionality is working fine. Reviewed By: nslingerland Differential Revision: D21668522 fbshipit-source-id: fa3b887c7b5dedc08c62a9d579e1112d7f8e0323 --- desktop/package.json | 3 ++- desktop/static/icons.json | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/desktop/package.json b/desktop/package.json index 52d9faca1..ac3a42967 100644 --- a/desktop/package.json +++ b/desktop/package.json @@ -254,5 +254,6 @@ }, "optionalDependencies": { "7zip-bin-mac": "^1.0.1" - } + }, + "dependencies": {} } diff --git a/desktop/static/icons.json b/desktop/static/icons.json index 5fb6ec451..4b4b44598 100644 --- a/desktop/static/icons.json +++ b/desktop/static/icons.json @@ -260,7 +260,8 @@ ], "triangle-down": [ 12, - 16 + 16, + 20 ], "triangle-right": [ 12 @@ -406,7 +407,8 @@ 12 ], "triangle-up": [ - 16 + 16, + 20 ], "checkmark-circle": [ 12