jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename network plugin

Browse Source 
Summary: Sonar -> Flipper. Class names only for now.

Reviewed By: priteshrnandgaonkar

Differential Revision: D9991029

fbshipit-source-id: b96dbab7acc89586c1ee67b64bef1c9490b560b5
This commit is contained in:
Pascal Hartig
2018-09-22 16:35:16 -07:00
committed by Facebook Github Bot
parent 52fb0fc1b8
commit c7f6893cb4
4 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
android/sample/src/main/java/com/facebook/flipper/sample/FlipperSampleApplication.java
View File

@@ -12,8 +12,8 @@ import com.facebook.flipper.plugins.inspector.DescriptorMapping;
import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin;
import com.facebook.flipper.plugins.leakcanary.LeakCanaryFlipperPlugin;
import com.facebook.flipper.plugins.litho.LithoFlipperDescriptors;
import com.facebook.flipper.plugins.network.NetworkSonarPlugin;
import com.facebook.flipper.plugins.network.SonarOkhttpInterceptor;
import com.facebook.flipper.plugins.network.NetworkFlipperPlugin;
import com.facebook.flipper.plugins.network.FlipperOkhttpInterceptor;
import com.facebook.flipper.plugins.sharedpreferences.SharedPreferencesSonarPlugin;
import java.util.concurrent.TimeUnit;
import okhttp3.OkHttpClient;
@@ -30,8 +30,8 @@ public class FlipperSampleApplication extends Application {
final FlipperClient client = AndroidFlipperClient.getInstance(this);
final DescriptorMapping descriptorMapping = DescriptorMapping.withDefaults();
NetworkSonarPlugin networkPlugin = new NetworkSonarPlugin();
SonarOkhttpInterceptor interceptor = new SonarOkhttpInterceptor(networkPlugin);
NetworkFlipperPlugin networkPlugin = new NetworkFlipperPlugin();
FlipperOkhttpInterceptor interceptor = new FlipperOkhttpInterceptor(networkPlugin);
okhttpClient = new OkHttpClient.Builder()
.addNetworkInterceptor(interceptor)

8
android/src/main/java/com/facebook/flipper/plugins/network/SonarOkhttpInterceptor.java → android/src/main/java/com/facebook/flipper/plugins/network/FlipperOkhttpInterceptor.java
View File

@@ -24,15 +24,15 @@ import okhttp3.Response;
import okhttp3.ResponseBody;
import okio.Buffer;
public class SonarOkhttpInterceptor implements Interceptor {
public class FlipperOkhttpInterceptor implements Interceptor {
public @Nullable NetworkSonarPlugin plugin;
public @Nullable NetworkFlipperPlugin plugin;
public SonarOkhttpInterceptor() {
public FlipperOkhttpInterceptor() {
this.plugin = null;
}
public SonarOkhttpInterceptor(NetworkSonarPlugin plugin) {
public FlipperOkhttpInterceptor(NetworkFlipperPlugin plugin) {
this.plugin = plugin;
}

6
android/src/main/java/com/facebook/flipper/plugins/network/NetworkSonarPlugin.java → android/src/main/java/com/facebook/flipper/plugins/network/NetworkFlipperPlugin.java
View File

@@ -15,16 +15,16 @@ import com.facebook.flipper.core.FlipperObject;
import com.facebook.flipper.plugins.common.BufferingFlipperPlugin;
import java.util.List;
public class NetworkSonarPlugin extends BufferingFlipperPlugin implements NetworkReporter {
public class NetworkFlipperPlugin extends BufferingFlipperPlugin implements NetworkReporter {
public static final String ID = "Network";
private final List<NetworkResponseFormatter> mFormatters;
public NetworkSonarPlugin() {
public NetworkFlipperPlugin() {
this(null);
}
public NetworkSonarPlugin(List<NetworkResponseFormatter> formatters) {
public NetworkFlipperPlugin(List<NetworkResponseFormatter> formatters) {
this.mFormatters = formatters;
}

8
docs/network-plugin.md
View File

@@ -14,9 +14,9 @@ To use the network plugin, you need to add the plugin to your Flipper client ins
### Android
```java
import com.facebook.sonar.plugins.network.NetworkSonarPlugin;
import com.facebook.sonar.plugins.network.NetworkFlipperPlugin;
NetworkSonarPlugin networkSonarPlugin = new NetworkSonarPlugin();
NetworkFlipperPlugin networkSonarPlugin = new NetworkFlipperPlugin();
client.addPlugin(networkSonarPlugin);
```
@@ -25,10 +25,10 @@ client.addPlugin(networkSonarPlugin);
If you are using the popular OkHttp library, you can use the Interceptors system to automatically hook into your existing stack.
```java
import com.facebook.sonar.plugins.network.SonarOkhttpInterceptor;
import com.facebook.sonar.plugins.network.FlipperOkhttpInterceptor;
new OkHttpClient.Builder()
.addNetworkInterceptor(new SonarOkhttpInterceptor(networkSonarPlugin))
.addNetworkInterceptor(new FlipperOkhttpInterceptor(networkSonarPlugin))
.build();
```