From c6efea991dd40e727a55474f89c9a7495bae955e Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Wed, 9 Jan 2019 10:40:21 -0800 Subject: [PATCH] Remove CrashReporter handlers Summary: This diff removes the custom global exception handler which was being used to send crash notifications. Removing it in the favour of next diff, where we detect crash by looking at Logcat Reviewed By: passy Differential Revision: D13590049 fbshipit-source-id: 2914d51b2c5f33c1cade4926dbbf72c041047c71 --- .../plugins/crashreporter/CrashReporterPlugin.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/crashreporter/CrashReporterPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/crashreporter/CrashReporterPlugin.java index 30a655fd5..fb73cb871 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/crashreporter/CrashReporterPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/crashreporter/CrashReporterPlugin.java @@ -40,19 +40,8 @@ public class CrashReporterPlugin implements FlipperPlugin { @Override public void onConnect(FlipperConnection connection) { mConnection = connection; - prevHandler = Thread.getDefaultUncaughtExceptionHandler(); - Thread.setDefaultUncaughtExceptionHandler( - new Thread.UncaughtExceptionHandler() { - @Override - public void uncaughtException(Thread paramThread, Throwable paramThrowable) { - sendExceptionMessage(paramThread, paramThrowable); - if (prevHandler != null) { - prevHandler.uncaughtException(paramThread, paramThrowable); - } - } - }); } - + // This function is called from Litho's error boundary. public void sendExceptionMessage(Thread paramThread, Throwable paramThrowable) { if (mConnection != null) { FlipperConnection connection = mConnection; @@ -77,7 +66,6 @@ public class CrashReporterPlugin implements FlipperPlugin { @Override public void onDisconnect() { mConnection = null; - Thread.setDefaultUncaughtExceptionHandler(prevHandler); } @Override