jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove RSocket

Browse Source 
Summary:
^
Changelog: Remove rsocket references from xplat

Reviewed By: aigoncharov

Differential Revision: D34418118

fbshipit-source-id: bd49b9da119e3a2a1ce396d14e0dca73e1b9c692
This commit is contained in:
Lorenzo Blasa
2022-02-24 23:56:22 -08:00
committed by Facebook GitHub Bot
parent c15605afd3
commit c4f80a826e
12 changed files with 10 additions and 667 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
xplat/FlipperTests/FlipperRSocketResponderTests.cpp
View File

@@ -1,70 +0,0 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include <Flipper/FlipperRSocketResponder.h>
#include <Flipper/Log.h>
#include <FlipperTestLib/FlipperConnectionManagerMock.h>
#include <folly/json.h>
#include <gtest/gtest.h>
namespace facebook {
namespace flipper {
namespace test {
using folly::dynamic;
class Callbacks
: public facebook::flipper::FlipperConnectionManager::Callbacks {
public:
void onConnected() {}
void onDisconnected() {}
void onMessageReceived(
const folly::dynamic& message,
std::unique_ptr<FlipperResponder> responder) {
message_ = message;
responder_ = std::move(responder);
}
folly::dynamic message_;
std::unique_ptr<FlipperResponder> responder_;
};
TEST(FlipperRSocketResponderTests, testFireAndForgetWithoutIdParam) {
auto socket = facebook::flipper::test::FlipperConnectionManagerMock();
auto callbacks = new Callbacks();
socket.setCallbacks(callbacks);
folly::EventBase* eb = new folly::EventBase();
auto responder = facebook::flipper::FlipperRSocketResponder(&socket, eb);
dynamic d = dynamic::object("my", "message");
auto json = folly::toJson(d);
responder.handleFireAndForget(rsocket::Payload(json), rsocket::StreamId(1));
EXPECT_EQ(socket.messagesReceived.size(), 1);
EXPECT_EQ(socket.messagesReceived[0]["my"], "message");
EXPECT_EQ(socket.respondersWithIdReceived, 0);
EXPECT_EQ(socket.respondersWithoutIdReceived, 1);
}
TEST(FlipperRSocketResponderTests, testFireAndForgetWithIdParam) {
auto socket = facebook::flipper::test::FlipperConnectionManagerMock();
auto callbacks = new Callbacks();
socket.setCallbacks(callbacks);
folly::EventBase* eb = new folly::EventBase();
auto responder = facebook::flipper::FlipperRSocketResponder(&socket, eb);
dynamic d = dynamic::object("my", "message")("id", 7);
auto json = folly::toJson(d);
responder.handleFireAndForget(rsocket::Payload(json), rsocket::StreamId(1));
EXPECT_EQ(socket.messagesReceived.size(), 1);
EXPECT_EQ(socket.messagesReceived[0]["my"], "message");
EXPECT_EQ(socket.messagesReceived[0]["id"], 7);
EXPECT_EQ(socket.respondersWithIdReceived, 1);
EXPECT_EQ(socket.respondersWithoutIdReceived, 0);
}
} // namespace test
} // namespace flipper
} // namespace facebook

86
xplat/FlipperTests/FlipperResponderImplTests.cpp
View File

@@ -1,86 +0,0 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include <Flipper/FlipperResponderImpl.h>
#include "yarpl/Flowable.h"
#include "yarpl/Single.h"
#include "yarpl/single/SingleTestObserver.h"
#include <folly/json.h>
#include <gtest/gtest.h>
namespace facebook {
namespace flipper {
namespace test {
using folly::dynamic;
void assertIsSuccess(folly::dynamic d);
void assertIsError(folly::dynamic d);
TEST(FlipperResponderImplTest, testSuccessWrapper) {
auto dynamicSingle =
yarpl::single::Single<folly::dynamic>::create([](auto observer) mutable {
observer->onSubscribe(yarpl::single::SingleSubscriptions::empty());
auto responder = std::make_shared<FlipperResponderImpl>(observer);
responder->success(folly::dynamic::object("my", "object"));
});
auto to = yarpl::single::SingleTestObserver<folly::dynamic>::create();
dynamicSingle->subscribe(to);
to->awaitTerminalEvent();
auto output = to->getOnSuccessValue();
assertIsSuccess(output);
EXPECT_EQ(output["success"]["my"], "object");
}
TEST(FlipperResponderImplTest, testErrorWrapper) {
auto dynamicSingle =
yarpl::single::Single<folly::dynamic>::create([](auto observer) mutable {
observer->onSubscribe(yarpl::single::SingleSubscriptions::empty());
auto responder = std::make_shared<FlipperResponderImpl>(observer);
responder->error(folly::dynamic::object("my", "object"));
});
auto to = yarpl::single::SingleTestObserver<folly::dynamic>::create();
dynamicSingle->subscribe(to);
to->awaitTerminalEvent();
auto output = to->getOnSuccessValue();
assertIsError(output);
EXPECT_EQ(output["error"]["my"], "object");
}
TEST(FlipperResponderImplTest, testNoExplicitResponseReturnsSuccess) {
auto to = yarpl::single::SingleTestObserver<folly::dynamic>::create();
{
auto dynamicSingle = yarpl::single::Single<folly::dynamic>::create(
[](auto observer) mutable {
observer->onSubscribe(yarpl::single::SingleSubscriptions::empty());
auto responder = std::make_shared<FlipperResponderImpl>(observer);
});
dynamicSingle->subscribe(to);
}
to->awaitTerminalEvent();
auto output = to->getOnSuccessValue();
assertIsSuccess(output);
EXPECT_TRUE(output["success"].empty());
}
void assertIsSuccess(folly::dynamic d) {
EXPECT_NE(d.find("success"), d.items().end());
EXPECT_EQ(d.find("error"), d.items().end());
}
void assertIsError(folly::dynamic d) {
EXPECT_NE(d.find("error"), d.items().end());
EXPECT_EQ(d.find("success"), d.items().end());
}
} // namespace test
} // namespace flipper
} // namespace facebook