jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Extract Responder class out of FlipperConnectionManagerImpl

Browse Source 
Summary:
For one thing, this file is too big so it's good to split it up.

Also, having this responder defined in the .cpp file makes it hard to test. Extracting it for testability.

Reviewed By: passy

Differential Revision: D14000079

fbshipit-source-id: 8da4e0e325f48c0ada8efc7cd6fffcb3440c6e26
This commit is contained in:
John Knox
2019-02-11 14:01:32 -08:00
committed by Facebook Github Bot
parent 4a3de26a88
commit c48c1a728a
4 changed files with 114 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
xplat/Flipper/FlipperConnectionManagerImpl.h
View File

@@ -19,11 +19,13 @@ namespace flipper {
class ConnectionEvents;
class ConnectionContextStore;
class Responder;
class FlipperRSocketResponder;
rsocket::Payload toRSocketPayload(folly::dynamic data);
class FlipperConnectionManagerImpl : public FlipperConnectionManager {
friend ConnectionEvents;
friend Responder;
friend FlipperRSocketResponder;
public:
FlipperConnectionManagerImpl(FlipperInitConfig config, std::shared_ptr<FlipperState> state, std::shared_ptr<ConnectionContextStore> contextStore);