jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed adding queries to favorites

Browse Source 
Summary: I found a bug after migration to Sandy. It is now not possible to add queries to favorites. This diff fixes the issue.

Reviewed By: mweststrate

Differential Revision: D28066435

fbshipit-source-id: 129a62dab9521160f8957abba70e5c7a6e609839
This commit is contained in:
Anton Nikolaev
2021-04-29 01:27:05 -07:00
committed by Facebook GitHub Bot
parent 05bf55419f
commit c4887e638b
1 changed files with 7 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
desktop/plugins/public/databases/index.tsx
View File

@@ -485,28 +485,21 @@ export function plugin(client: PluginClient<Events, Methods>) {
const updateFavorites = (event: {favorites: Array<string> | undefined}) => { const updateFavorites = (event: {favorites: Array<string> | undefined}) => {
const state = pluginState.get(); const state = pluginState.get();
let newFavorites = event.favorites || state.favorites; const newFavorites = [...(event.favorites || state.favorites)];
if ( if (state.query) {
state.query &&
state.query !== null &&
typeof state.query !== 'undefined'
) {
const value = state.query.value; const value = state.query.value;
if (newFavorites.includes(value)) { const index = newFavorites.indexOf(value);
const index = newFavorites.indexOf(value); if (index < 0) {
newFavorites.splice(index, 1); newFavorites.push(value);
} else { } else {
newFavorites = state.favorites.concat(value); newFavorites.splice(index, 1);
} }
} }
pluginState.set({...state, favorites: newFavorites});
window.localStorage.setItem( window.localStorage.setItem(
'plugin-database-favorites-sql-queries', 'plugin-database-favorites-sql-queries',
JSON.stringify(newFavorites), JSON.stringify(newFavorites),
); );
return {
...state,
favorites: newFavorites,
};
}; };
const sortByChanged = (event: {sortOrder: TableRowSortOrder}) => { const sortByChanged = (event: {sortOrder: TableRowSortOrder}) => {