jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Better form validation for required parameters plus live editing

Browse Source 
Summary: Taking on the feedback from the demo yesterday, I've improved the required parameter's dialog by showing where specific errors occur in the form and adding live editing to the URI displayed.

Reviewed By: danielbuechele

Differential Revision: D16802921

fbshipit-source-id: 2e729549306a8efb79ca76d3da6f70632ccd9212
This commit is contained in:
Benjamin Elo
2019-08-14 05:24:39 -07:00
committed by Facebook Github Bot
parent 1ae3b90019
commit c40a88b117
4 changed files with 57 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/navigation/index.js
View File

@@ -112,11 +112,12 @@ export default class extends FlipperPlugin<State, {}, PersistedState> {
};
navigateTo = (query: string) => {
this.props.setPersistedState({currentURI: query});
const requiredParameters = getRequiredParameters(query);
const filteredQuery = filterOptionalParameters(query);
this.props.setPersistedState({currentURI: filteredQuery});
const requiredParameters = getRequiredParameters(filteredQuery);
if (requiredParameters.length === 0) {
this.getDevice().then(device => {
device.navigateToLocation(filterOptionalParameters(query));
device.navigateToLocation(filterOptionalParameters(filteredQuery));
});
} else {
this.setState({