From c3bc1682162314ff8ad7ec7638d0a1d0906b627f Mon Sep 17 00:00:00 2001 From: Chaiwat Ekkaewnumchai Date: Thu, 7 May 2020 03:37:49 -0700 Subject: [PATCH] (client) Change Inspector Descriptor Summary: Previously, descriptor stopped iteration (searching) as soon as it finds hit element. This diff changes so that it will always do complete search Reviewed By: mweststrate Differential Revision: D21040424 fbshipit-source-id: 9123c6382dcdfefd6df17a95d283f5123906df11 --- .../plugins/inspector/descriptors/ViewGroupDescriptor.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java index 40b490389..bddf55e04 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewGroupDescriptor.java @@ -253,6 +253,7 @@ public class ViewGroupDescriptor extends NodeDescriptor { } private void runHitTest(ViewGroup node, Touch touch) { + boolean finish = true; for (int i = node.getChildCount() - 1; i >= 0; i--) { final View child = node.getChildAt(i); if (child instanceof HiddenNode @@ -273,11 +274,11 @@ public class ViewGroupDescriptor extends NodeDescriptor { if (hit) { touch.continueWithOffset(i, left, top); - return; + finish = false; } } - touch.finish(); + if (finish) touch.finish(); } @Override