From c3013ae57b32a60ee8b7556fed2702b4a9ebd2ab Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Wed, 24 May 2023 04:19:58 -0700 Subject: [PATCH] Rename no-op package namespace (#4754) Summary: [android] Rename no-op package namespace Shouldn't affect anything but otherwise you get a warning: ``` [:android] /Users/realpassy/Projects/java/flipper/android/build/intermediates/merged_manifest/debug/AndroidManifest.xml Warning: Namespace 'com.facebook.flipper' used in: :android, com.facebook.flipper:flipper:0.182.0. ``` Pull Request resolved: https://github.com/facebook/flipper/pull/4754 Test Plan: CI Build sample --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/flipper/pull/4754). * https://github.com/facebook/flipper/issues/4759 * https://github.com/facebook/flipper/issues/4758 * https://github.com/facebook/flipper/issues/4757 * https://github.com/facebook/flipper/issues/4756 * https://github.com/facebook/flipper/issues/4755 * __->__ https://github.com/facebook/flipper/issues/4754 * https://github.com/facebook/flipper/issues/4753 * https://github.com/facebook/flipper/issues/4752 * https://github.com/facebook/flipper/issues/4751 Reviewed By: ivanmisuno Differential Revision: D46068943 Pulled By: passy fbshipit-source-id: ac806cd1c8444875fe965c95095ba886592e72d0 --- android/no-op/build.gradle | 2 +- android/no-op/src/main/AndroidManifest.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/android/no-op/build.gradle b/android/no-op/build.gradle index ac84a9a41..3caf12b4c 100644 --- a/android/no-op/build.gradle +++ b/android/no-op/build.gradle @@ -8,7 +8,7 @@ apply plugin: 'com.android.library' android { - namespace 'com.facebook.flipper' + namespace 'com.facebook.flipper.noop' compileSdkVersion rootProject.compileSdkVersion buildToolsVersion rootProject.buildToolsVersion diff --git a/android/no-op/src/main/AndroidManifest.xml b/android/no-op/src/main/AndroidManifest.xml index 674594014..260fd956e 100644 --- a/android/no-op/src/main/AndroidManifest.xml +++ b/android/no-op/src/main/AndroidManifest.xml @@ -7,5 +7,5 @@ --> + package="com.facebook.flipper.noop">