jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update instruments check

Browse Source 
Summary: We no longer need to check for instruments but it's useful to check if we have xctrace as it was added somewhat recently to xcrun.

Reviewed By: mweststrate

Differential Revision: D31232872

fbshipit-source-id: 0f496c56520bf752cf7dbd5005c7832c80c2bc26
This commit is contained in:
Pascal Hartig
2021-09-28 08:19:51 -07:00
committed by Facebook GitHub Bot
parent 795a3d30a0
commit c2848df7f2
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
desktop/doctor/src/index.ts
View File

@@ -236,15 +236,17 @@ export function getHealthchecks(): Healthchecks {
}, },
}, },
{ {
key: 'ios.instruments', key: 'ios.xctrace',
label: 'Instruments exists', label: 'xctrace exists',
isRequired: true, isRequired: true,
run: async (_: EnvironmentInfo) => { run: async (_: EnvironmentInfo) => {
const result = await tryExecuteCommand('which instruments'); const result = await tryExecuteCommand(
'xcrun xctrace version',
);
const hasProblem = result.hasProblem; const hasProblem = result.hasProblem;
const message = hasProblem const message = hasProblem
? `Instruments not found. Please try to re-install Xcode (https://developer.apple.com/xcode/). ${result.message}.` ? `xctrace is not available. Please ensure you have Xcode installed and are running a recent version (https://developer.apple.com/xcode/). ${result.message}.`
: `Instruments are installed. ${result.message}.`; : `xctrace is available. ${result.message}.`;
return { return {
hasProblem, hasProblem,
message, message,