Dev mode: fixed loading plugins located outside of the Flipper source root folder

Summary: Dev mode: fixed loading of plugins located outside of the Flipper source root folder, e.g. in ~/flipper-plugins as suggested in tutorial docs.

Reviewed By: passy

Differential Revision: D21306639

fbshipit-source-id: bb9044b25324065f0c12169b95fbe663da8d4305

desktop/babel-transformer/src/plugin-flipper-requires.ts

@@ -0,0 +1,74 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+import {CallExpression, Identifier, isStringLiteral} from '@babel/types';
+import {NodePath} from '@babel/traverse';
+import {resolve, dirname} from 'path';
+
+import {
+  tryReplaceFlipperRequire,
+  tryReplaceGlobalReactUsage,
+} from './replace-flipper-requires';
+
+// do not apply this transform for these paths
+const EXCLUDE_PATHS = [
+  '/node_modules/react-devtools-core/',
+  'relay-devtools/DevtoolsUI',
+];
+function isExcludedPath(path: string) {
+  for (const epath of EXCLUDE_PATHS) {
+    if (path.indexOf(epath) > -1) {
+      return true;
+    }
+  }
+  return false;
+}
+module.exports = () => ({
+  visitor: {
+    CallExpression(path: NodePath<CallExpression>, state: any) {
+      if (isExcludedPath(state.file.opts.filename)) {
+        return;
+      }
+      if (!tryReplaceFlipperRequire(path)) {
+        const node = path.node;
+        const args = node.arguments || [];
+        if (
+          node.callee.type === 'Identifier' &&
+          node.callee.name === 'require' &&
+          args.length === 1 &&
+          isStringLiteral(args[0]) &&
+          // require a file not a pacakge
+          args[0].value.indexOf('/') > -1 &&
+          // in the plugin itself and not inside one of its dependencies
+          state.file.opts.filename.indexOf('node_modules') === -1 &&
+          // the resolved path for this file is outside the plugins root
+          !resolve(
+            state.file.opts.root,
+            dirname(state.file.opts.filename),
+            args[0].value,
+          ).startsWith(state.file.opts.root)
+        ) {
+          throw new Error(
+            `Plugins cannot require files from outside their folder. Attempted to require ${resolve(
+              state.file.opts.root,
+              dirname(state.file.opts.filename),
+              args[0].value,
+            )} which isn't inside ${state.file.opts.root}`,
+          );
+        }
+      }
+    },
+    Identifier(path: NodePath<Identifier>, state: any) {
+      if (isExcludedPath(state.file.opts.filename)) {
+        return;
+      }
+      tryReplaceGlobalReactUsage(path);
+    },
+  },
+});