From c1f6ca84b6844824108ce17771856c401b61b21c Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Fri, 10 Dec 2021 17:58:06 -0800 Subject: [PATCH] Fix overflow issue in WelcomeScreen Summary: Noticed that the welcome screen started bleeding in the sidebar when the screen is too small. Unlike the plugin container it lacked an overflow: hidden. Reviewed By: timur-valiev, aigoncharov Differential Revision: D32987160 fbshipit-source-id: be324247cdb4abfeec12c40624d65f9fa1e86eff --- desktop/flipper-ui-core/src/sandy-chrome/SandyApp.tsx | 1 + desktop/flipper-ui-core/src/sandy-chrome/WelcomeScreen.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/desktop/flipper-ui-core/src/sandy-chrome/SandyApp.tsx b/desktop/flipper-ui-core/src/sandy-chrome/SandyApp.tsx index 626965530..1dc95f16f 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/SandyApp.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/SandyApp.tsx @@ -224,6 +224,7 @@ const outOfContentsContainer = ( const MainContainer = styled(Layout.Container)({ background: theme.backgroundWash, padding: `${theme.space.large}px ${theme.space.large}px ${theme.space.large}px 0`, + overflow: 'hidden', }); const RootElement = styled.div({ diff --git a/desktop/flipper-ui-core/src/sandy-chrome/WelcomeScreen.tsx b/desktop/flipper-ui-core/src/sandy-chrome/WelcomeScreen.tsx index 8c278c805..c7ad449ad 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/WelcomeScreen.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/WelcomeScreen.tsx @@ -129,6 +129,7 @@ export function WelcomeScreenStaticView() { center style={{ justifyContent: 'center', + overflow: 'hidden', }} pad grow>