jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RCMountable -> CKMountable (#4522)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/4522

^

A codemod changed the name of `CKMountable` for the OSS ComponentKit integration, this is a breaking change as we are pinned to a specific Cocoapods version of CK.

Reviewed By: passy

Differential Revision: D43303489

fbshipit-source-id: 4d8ad472735414ca8e67a8ce4409efe84aab3e94
This commit is contained in:
Lorenzo Blasa
2023-02-15 03:55:28 -08:00
committed by Facebook GitHub Bot
parent 362cea3126
commit c1badd1a29
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutWrapper.mm
View File

@@ -23,8 +23,8 @@
static char const kLayoutWrapperKey = ' '; static char const kLayoutWrapperKey = ' ';
static CK::Optional<CKFlexboxComponentChild> findFlexboxLayoutParams( static CK::Optional<CKFlexboxComponentChild> findFlexboxLayoutParams(
id<RCMountable> parent, id<CKMountable> parent,
id<RCMountable> child) { id<CKMountable> child) {
if ([parent isKindOfClass:[CKFlexboxComponent class]]) { if ([parent isKindOfClass:[CKFlexboxComponent class]]) {
static Ivar ivar = static Ivar ivar =
class_getInstanceVariable([CKFlexboxComponent class], "_children"); class_getInstanceVariable([CKFlexboxComponent class], "_children");
@@ -59,7 +59,7 @@ static CK::Optional<CKFlexboxComponentChild> findFlexboxLayoutParams(
return cachedWrapper; return cachedWrapper;
} }
} }
// TODO: Add support for `RCMountable` components. // TODO: Add support for `CKMountable` components.
CKComponent* component = (CKComponent*)layout.component; CKComponent* component = (CKComponent*)layout.component;
CKComponentReuseWrapper* reuseWrapper = CKComponentReuseWrapper* reuseWrapper =
CKAnalyticsListenerHelpers::GetReusedNodes(component); CKAnalyticsListenerHelpers::GetReusedNodes(component);