From c010e226126ef806414e917f4a946e73c32c7e37 Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Mon, 22 Feb 2021 03:35:55 -0800 Subject: [PATCH] Reduce errors from androidDevice Summary: None of these are fatal. In fact, they're quite common for people who've got Android enabled but no tools installed. So they're warnings at best. I'd like to find a way to guide people to the settings in this case or use Doctor to disable Android support instead of retrying this endlessly. Reviewed By: mweststrate Differential Revision: D26547577 fbshipit-source-id: 81e658fe3d95b2d12e76e4b635575f3e5a6fc53b --- desktop/app/src/dispatcher/androidDevice.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/desktop/app/src/dispatcher/androidDevice.tsx b/desktop/app/src/dispatcher/androidDevice.tsx index 6d088d281..0ed6bac0d 100644 --- a/desktop/app/src/dispatcher/androidDevice.tsx +++ b/desktop/app/src/dispatcher/androidDevice.tsx @@ -144,7 +144,7 @@ export default (store: Store, logger: Logger) => { `${emulatorPath} -list-avds`, (error: Error | null, data: string | null) => { if (error != null || data == null) { - console.error(error || 'Failed to list AVDs'); + console.warn('List AVD failed: ', error); return; } const payload = data.split('\n').filter(Boolean); @@ -172,7 +172,7 @@ export default (store: Store, logger: Logger) => { .map((device: BaseDevice) => device.serial); unregisterDevices(deviceIDsToRemove); - console.error('adb server was shutdown'); + console.warn('adb server was shutdown'); setTimeout(watchAndroidDevices, 500); } else { throw err; @@ -206,7 +206,7 @@ export default (store: Store, logger: Logger) => { }); }) .catch((e) => { - console.error(`Failed to watch for android devices: ${e.message}`); + console.warn(`Failed to watch for android devices: ${e.message}`); }); };