Fix to avoid loading of disabled device plugins
Summary: There is a bug right now that even for disabled plugins we're loading them. In particular, this led to the Flipper freezes caused by Logs plugin even if it is disabled. Reviewed By: passy Differential Revision: D26503012 fbshipit-source-id: 2068626f4637ced44c457ee1b7ba7fffdcf5aa47
This commit is contained in:
committed by
Facebook GitHub Bot
parent
805261b429
commit
c0010bea4c
@@ -212,13 +212,16 @@ export default class BaseDevice {
|
||||
}
|
||||
|
||||
loadDevicePlugins(
|
||||
devicePlugins?: DevicePluginMap,
|
||||
devicePlugins: DevicePluginMap,
|
||||
enabledDevicePlugins: Set<string>,
|
||||
pluginStates?: Record<string, any>,
|
||||
) {
|
||||
if (!devicePlugins) {
|
||||
return;
|
||||
}
|
||||
const plugins = Array.from(devicePlugins.values());
|
||||
const plugins = Array.from(devicePlugins.values()).filter((p) =>
|
||||
enabledDevicePlugins?.has(p.id),
|
||||
);
|
||||
for (const plugin of plugins) {
|
||||
this.loadDevicePlugin(plugin, pluginStates?.[plugin.id]);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user