Remove RecurringError type

Summary:
This was originally introduced so we could squash multiple instances of the same error at the client side and only report one instance of them.
Now we've moved to doing the aggregation server side, which is more powerful, so this is no longer necessary. We've also seen a case of these Error objects appearing opaque making it hard to see the underlying problem, so removing it entirely.

Reviewed By: passy

Differential Revision: D14576715

fbshipit-source-id: b285dcb5249e209f9008a14ac6a2f226f3aa82d7

src/server.js

@@ -16,7 +16,6 @@ import RSocketTCPServer from 'rsocket-tcp-server';
 import {Single} from 'rsocket-flowable';
 import Client from './Client.js';
 import type {UninitializedClient} from './UninitializedClient';
-import {RecurringError} from './utils/errors';
 import {reportPlatformFailures} from './utils/metrics';
 
 const EventEmitter = (require('events'): any);
@@ -342,11 +341,9 @@ class ConnectionTracker {
     this.connectionAttempts.set(key, entry);
     if (entry.length >= this.connectionProblemThreshold) {
       console.error(
-        new RecurringError(
-          `Connection loop detected with ${key}. Connected ${
-            this.connectionProblemThreshold
-          } times within ${this.timeWindowMillis / 1000}s.`,
-        ),
+        `Connection loop detected with ${key}. Connected ${
+          this.connectionProblemThreshold
+        } times within ${this.timeWindowMillis / 1000}s.`,
         'server',
       );
     }