Clean up SandySettingsPanel

Summary: The fb and non-fb sandy settings are now identical (see diff 1 of this stack), so inlined the component and dropped the files

Reviewed By: priteshrnandgaonkar

Differential Revision: D25824522

fbshipit-source-id: 5a388b3f7259cb96f0e45ceb3363c40e4f198d7b
This commit is contained in:
Michel Weststrate
2021-01-18 06:45:17 -08:00
committed by Facebook GitHub Bot
parent ffeb47ed75
commit bf6655a640
2 changed files with 10 additions and 30 deletions

View File

@@ -25,7 +25,6 @@ import KeyboardShortcutInput from './settings/KeyboardShortcutInput';
import {isEqual, isMatch, isEmpty} from 'lodash'; import {isEqual, isMatch, isEmpty} from 'lodash';
import restartFlipper from '../utils/restartFlipper'; import restartFlipper from '../utils/restartFlipper';
import LauncherSettingsPanel from '../fb-stubs/LauncherSettingsPanel'; import LauncherSettingsPanel from '../fb-stubs/LauncherSettingsPanel';
import SandySettingsPanel from '../fb-stubs/SandySettingsPanel';
import {reportUsage} from '../utils/metrics'; import {reportUsage} from '../utils/metrics';
import {Modal, message} from 'antd'; import {Modal, message} from 'antd';
import {Layout, withTrackingScope, _NuxManagerContext} from 'flipper-plugin'; import {Layout, withTrackingScope, _NuxManagerContext} from 'flipper-plugin';
@@ -261,7 +260,8 @@ class SettingsSheet extends Component<Props, State> {
}); });
}} }}
/> />
<SandySettingsPanel <ToggledSection
label="Disable Sandy UI"
toggled={this.state.updatedSettings.disableSandy} toggled={this.state.updatedSettings.disableSandy}
onChange={(v) => { onChange={(v) => {
this.setState({ this.setState({
@@ -274,8 +274,14 @@ class SettingsSheet extends Component<Props, State> {
disableSandy: v, disableSandy: v,
}, },
}); });
}} }}>
/> {' '}
<ConfigText
content={
'If disabled, Flipper will fall back to the classic design.'
}
/>
</ToggledSection>
{!disableSandy && ( {!disableSandy && (
<ToggledSection <ToggledSection
label="Enable dark theme (experimental)" label="Enable dark theme (experimental)"

View File

@@ -1,26 +0,0 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
*/
import React from 'react';
import ToggledSection from '../chrome/settings/ToggledSection';
import {ConfigText} from '../chrome/settings/configFields';
export default function (props: {
toggled: boolean;
onChange: (value: boolean) => void;
}) {
return (
<ToggledSection {...props} label="Disable Sandy UI">
{' '}
<ConfigText
content={'If disabled, Flipper will fall back to the classic design.'}
/>
</ToggledSection>
);
}