From beaf4997fe75b59142c60a1c63f906da8cb31695 Mon Sep 17 00:00:00 2001
From: Benjamin Elo <beneloca@fb.com>
Date: Mon, 12 Aug 2019 05:49:44 -0700
Subject: [PATCH] Migrated DevicesButton from js to ts

Summary: Migrated DevicesButton from JS to TS

Reviewed By: passy

Differential Revision: D16730841

fbshipit-source-id: 3bfdb7945d82661f03d6a5b44b5404541a1b2c33
---
 .../{DevicesButton.js => DevicesButton.tsx}   | 46 +++++++++++--------
 src/chrome/TitleBar.tsx                       |  2 +-
 2 files changed, 28 insertions(+), 20 deletions(-)
 rename src/chrome/{DevicesButton.js => DevicesButton.tsx} (78%)

diff --git a/src/chrome/DevicesButton.js b/src/chrome/DevicesButton.tsx
similarity index 78%
rename from src/chrome/DevicesButton.js
rename to src/chrome/DevicesButton.tsx
index 1c02a45d5..cf778e2ff 100644
--- a/src/chrome/DevicesButton.js
+++ b/src/chrome/DevicesButton.tsx
@@ -5,27 +5,35 @@
  * @format
  */
 
-import {Component, Button, styled} from 'flipper';
+import {Button, styled} from 'flipper';
 import {connect} from 'react-redux';
 import {spawn} from 'child_process';
 import {dirname} from 'path';
-import {selectDevice, preferDevice} from '../reducers/connections.tsx';
+import {selectDevice, preferDevice} from '../reducers/connections';
 import {default as which} from 'which';
 import {promisify} from 'util';
-import {showOpenDialog} from '../utils/exportData.tsx';
+import {showOpenDialog} from '../utils/exportData';
 import PropTypes from 'prop-types';
-import type BaseDevice from '../devices/BaseDevice.tsx';
+import BaseDevice from '../devices/BaseDevice';
+import React, {Component} from 'react';
+import {State} from '../reducers';
 
 const whichPromise = promisify(which);
 
-type Props = {
-  selectedDevice: ?BaseDevice,
-  androidEmulators: Array<string>,
-  devices: Array<BaseDevice>,
-  selectDevice: (device: BaseDevice) => void,
-  preferDevice: (device: string) => void,
+type StateFromProps = {
+  selectedDevice: BaseDevice | null | undefined;
+  androidEmulators: Array<string>;
+  devices: Array<BaseDevice>;
 };
 
+type DispatchFromProps = {
+  selectDevice: (device: BaseDevice) => void;
+  preferDevice: (device: string) => void;
+};
+
+type OwnProps = {};
+
+type Props = OwnProps & StateFromProps & DispatchFromProps;
 const DropdownButton = styled(Button)({
   fontSize: 11,
 });
@@ -39,8 +47,8 @@ class DevicesButton extends Component<Props> {
     // On Linux, you must run the emulator from the directory it's in because
     // reasons ...
     whichPromise('emulator')
-      .catch(e => `${process.env.ANDROID_HOME || ''}/tools/emulator`)
-      .then(emulatorPath => {
+      .catch(() => `${process.env.ANDROID_HOME || ''}/tools/emulator`)
+      .then((emulatorPath: string) => {
         const child = spawn(emulatorPath, [`@${name}`], {
           detached: true,
           cwd: dirname(emulatorPath),
@@ -64,14 +72,14 @@ class DevicesButton extends Component<Props> {
     let buttonLabel = 'No device selected';
     let icon = 'minus-circle';
 
-    if (selectedDevice?.isArchived) {
-      buttonLabel = `${selectedDevice?.title || 'Unknown device'} (offline)`;
+    if (selectedDevice && selectedDevice.isArchived) {
+      buttonLabel = `${selectedDevice.title || 'Unknown device'} (offline)`;
       icon = 'box';
-    } else if (selectedDevice?.deviceType === 'physical') {
-      buttonLabel = selectedDevice?.title || 'Unknown device';
+    } else if (selectedDevice && selectedDevice.deviceType === 'physical') {
+      buttonLabel = selectedDevice.title || 'Unknown device';
       icon = 'mobile';
-    } else if (selectedDevice?.deviceType === 'emulator') {
-      buttonLabel = selectedDevice?.title || 'Unknown emulator';
+    } else if (selectedDevice && selectedDevice.deviceType === 'emulator') {
+      buttonLabel = selectedDevice.title || 'Unknown emulator';
       icon = 'desktop';
     }
 
@@ -172,7 +180,7 @@ class DevicesButton extends Component<Props> {
     );
   }
 }
-export default connect<Props, {||}, _, _, _, _>(
+export default connect<StateFromProps, DispatchFromProps, OwnProps, State>(
   ({connections: {devices, androidEmulators, selectedDevice}}) => ({
     devices,
     androidEmulators,
diff --git a/src/chrome/TitleBar.tsx b/src/chrome/TitleBar.tsx
index c4385e0bd..b7dcf27d6 100644
--- a/src/chrome/TitleBar.tsx
+++ b/src/chrome/TitleBar.tsx
@@ -27,7 +27,7 @@ import {
 } from 'flipper';
 import {connect} from 'react-redux';
 import RatingButton from './RatingButton.js';
-import DevicesButton from './DevicesButton.js';
+import DevicesButton from './DevicesButton';
 import ScreenCaptureButtons from './ScreenCaptureButtons.js';
 import AutoUpdateVersion from './AutoUpdateVersion';
 import UpdateIndicator from './UpdateIndicator';