From be641441d96397bbf123c10233061d6a12556d80 Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Thu, 27 Aug 2020 08:52:53 -0700 Subject: [PATCH] Add access token as a param in cdn link and minor improvements Summary: This fixes two issues. One issue where the recent change of cdn to lookaside hostname broke our build download process. More about this can be found [here](https://fb.workplace.com/groups/flipperfyi/permalink/772986153467682/). It also fixes a bug which occurred on a retry when an error happened. Recently I made changes where, if the build is downloaded then retrying shouldn't redownload it. But we used to remove the downloaded builds after install phase, so this diff just removes the build when the download is successfull. Reviewed By: nikoant Differential Revision: D23372251 fbshipit-source-id: b57e69f65a20fc123191962d60165a62859d4ef7 --- desktop/app/src/fb-stubs/user.tsx | 6 ++++++ desktop/app/src/index.tsx | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/desktop/app/src/fb-stubs/user.tsx b/desktop/app/src/fb-stubs/user.tsx index cbf0e855b..859722708 100644 --- a/desktop/app/src/fb-stubs/user.tsx +++ b/desktop/app/src/fb-stubs/user.tsx @@ -83,3 +83,9 @@ export async function getFlipperMediaCDN( export async function getPreferredEditorUriScheme(): Promise { return 'vscode'; } + +export const appendAccessTokenToUrl: ( + url: URL, +) => Promise = async () => { + return Promise.reject(new Error('Implement appendAccessTokenToUrl')); +}; diff --git a/desktop/app/src/index.tsx b/desktop/app/src/index.tsx index 61c1eb2c6..e385cf7f9 100644 --- a/desktop/app/src/index.tsx +++ b/desktop/app/src/index.tsx @@ -188,7 +188,7 @@ export {Console} from './ui/components/console'; export {default as Sheet} from './ui/components/Sheet'; export {default as FileSelector} from './ui/components/FileSelector'; export {KeyboardActions} from './MenuBar'; -export {getFlipperMediaCDN} from './fb-stubs/user'; +export {getFlipperMediaCDN, appendAccessTokenToUrl} from './fb-stubs/user'; export {Rect} from './utils/geometry'; export {Logger} from './fb-interfaces/Logger'; export {getInstance as getLogger} from './fb-stubs/Logger';