From be360157f6f7f8f97bdbb1441b46689cdbfa471d Mon Sep 17 00:00:00 2001 From: Lucas Bento Date: Thu, 27 Feb 2020 09:30:17 -0800 Subject: [PATCH] Add DMG target to mac distribution (#833) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Fixes https://github.com/facebook/flipper/issues/807 by adding a DMG target to distribute the application for mac. The `.dmg` file is `97.2 MB` while the `.zip` is `101.5 MB`. 😄 ![image](https://user-images.githubusercontent.com/6207220/75275890-7c32b480-5805-11ea-9d05-9a4f47d03562.png) ## Changelog Add DMG target for mac distribution Pull Request resolved: https://github.com/facebook/flipper/pull/833 Test Plan: 1. `yarn build --mac`; 1. Check `flipper-mac.dmg` inside of `dist`. --- **The background is completely discussable, I borrowed it [from an old project](https://github.com/lucasbento/react-native-actions/tree/feature/electron/packages/electron-react-native-actions) of mine and it's [totally not inspired by WebStorm `.dmg` file](https://user-images.githubusercontent.com/6207220/75276024-b3a16100-5805-11ea-8c69-063fe28316c1.png).** Reviewed By: nikoant Differential Revision: D20139188 Pulled By: passy fbshipit-source-id: 1aaaabd7c6ac51d12865388bf962d164f80a7a14 --- package.json | 21 +++++++++++++++++++++ scripts/build-release.ts | 2 +- static/dmgBackground.png | Bin 0 -> 14810 bytes 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 static/dmgBackground.png diff --git a/package.json b/package.json index 80dfad330..ceee53581 100644 --- a/package.json +++ b/package.json @@ -25,6 +25,27 @@ "NSUserNotificationAlertStyle": "alert" } }, + "dmg": { + "background": "dmgBackground.png", + "icon": "icon.icns", + "iconSize": 155, + "window": { + "width": 660, + "height": 400 + }, + "contents": [ + { + "x": 123, + "y": 172 + }, + { + "x": 539, + "y": 168, + "type": "link", + "path": "/Applications" + } + ] + }, "win": { "publisherName": "Facebook, Inc.", "sign": null diff --git a/scripts/build-release.ts b/scripts/build-release.ts index f0113801a..fbbafbb6b 100755 --- a/scripts/build-release.ts +++ b/scripts/build-release.ts @@ -67,7 +67,7 @@ async function buildDist(buildFolder: string) { const postBuildCallbacks: (() => void)[] = []; if (process.argv.indexOf('--mac') > -1) { - targetsRaw.push(Platform.MAC.createTarget(['dir'])); + targetsRaw.push(Platform.MAC.createTarget(['dir', 'dmg'])); postBuildCallbacks.push(() => spawn('zip', ['-qyr9', '../Flipper-mac.zip', 'Flipper.app'], { cwd: path.join(__dirname, '..', 'dist', 'mac'), diff --git a/static/dmgBackground.png b/static/dmgBackground.png new file mode 100644 index 0000000000000000000000000000000000000000..6ccc8750501ce5944e39023f052b18ff9169532b GIT binary patch literal 14810 zcmeHuXIzs>^e!MM;))_7DpjJOA|*%-C8!ugs(_+Y0qGq=LJue|Doq9H39xh#Q0XmM zr9=S%=@1|ilu(1T1QL?mm)-S$@BMtg-Ji(^=FB^pnKSR4bDnw5@YKvi|1jTaJ`N6! z!v;6>%sDu?QaLy{pY!eqYL3?ZtOx#ZyInE9!ol$_`OvN-4DS!u~l;x3quy4T6MdOa0RV0+jcv6{IBpX#)4smbzsf9DDJ zaQ)vS`3C)`7NDTQ-V+6|yrRPY^bPz}Yp)h!8tCByjJ(&s4p{4-mj74Xf8%H=><#{Z zOy*xr|EUF3)#1}p_@8Cd;WPRubB}{VtM4dRQEhlcfO(;`YArH7s8=GR<)>o?`! zc6cd{@BqbT5RW{(Dyh#IX_{0q!d}d=U=I#}qBK`(2KSRO;gpyQMlgL=Zujv2nZ-YDcTwX2B(hlTC(HClPjHy+A=4aEW_a^0|&9CX&8$FkUu5a5fuGAAT z^{*l4({(|BPO!~4glsO2EvVe7^U&R&ZJZ+BZ$JFB@ojX$yJy4<8mmnW;w4bK_G=sW z{ZvzZ1m-LMo{5u)Vkktd#pfOo*V_KEHj6*9yX3%zL;#A7>qLfcUW?XcAMK}YCL@;p z!e1D&2Lof)E9$4SyqR00#HG(Nxo;9VzG$wtsM!S%-)2;{QYY98etyRoDd~Tou<>5o zExlDh&GM-mrx>cBzQ52{O`t9MmI-!wnGU6K#881rQ>9qG=VCi`Wm1s1@BuJhG{~@AIWO$! z{0&L2?>hwF=9LCbO2cd%_~TlI#O}8PpuL4ID9LbowkFm(?acl9Xog2|roDvHgHK{p z7c`4qvoGi*3!7A-os%?J0>a!86X>luK)=!Ejix){iP(~1YrV)O+5Trt(;smyP}cUW z!JtM8n?=J}{qd>KX^5QRz*QmZ3_u%x zhuF^sPNez4*v}N)iGJy5yE?=Mj|YD0I|@S{^i<3+4T;8fj*_>JCeje*0cG)E}7NBhIYH_yjguF(l_NZn*%SZdm&3ui*rt)qd4Y@U$v$6na6^XKOKM_%a&Txg&uW(%qn>qA2<+s z!Bl-FwiU|W-MBDN_yhbP{0`LJv{~`Rp~CXjByH;0EJp@W=|uYGQjA7S9C4QD{BpTZYZkkf=$DY~_~)sn;43$+2$ato z9-hzR<(u4D4NLu(s(?N72RMfHcSFM*dfY9SS<&zp{fqkQZV@YR%_^r{1J#myB4lgW z%8m6s#k4pF@H~SIckf-)<~J+s`m5wHl3IT7rncbAwGawdML*l}*m>0Mtc0J4l_0-C z{d>*rZ;z6}!#62@E?ZTHF5!09{d}swsN(VIh1aG5BlKHtTB;PGrhlaY?jq<CDl7*P{kB1a; z)Z}gNYO0v`sD%1P3`U(R*>7RRWp}X9CU!bvM ze~$5*J#u1x0H0Pn&oUOOVwm4g{FcdeN6xHR77ntk*i6Umy2Nh>LaZ1*{3jK^6`VX3 z<&x!5yz`bBw8F-+SqwL$A9&T0B#4n%-w~s#r#QD~x2iW+v%jXLv|oUv?9xYZQ7Ts_ zr@-%+hXdAzFR#=O58_NA3x(I6^a2U=RBaE<6jPlYP4G>+cR~*KbiP-UA_hziPCBmK z=C-JO`!+p&E;=FUY<4ENSA90&F^TBAie*qHJ)i{@I!Vlki?F!dCr~_|;XZe~bhcH| z&h~BNz%<}4BVxM^oz7MxW^AlWWT12mru3eSTFga8?!*BE{J4n9A)g#M2kA31=r9nu@y360Gh zxA^-Wuq))Zza~e)@lNq_s+9$Sl?|k4ReM`L8_HO&F7H4Gc0O(!5o@h1$D7}e031un zGfhelV$3lPooX*pV0eJ?4ljPB=vIrmgL^aY*^NTHGiAcmHPayKne449)EDs>*Q9iZsL&g`HfJC9w!C{6_DM|Q z3S~|J1hXCcjh8 zn`~~zM!T8kB|t{otQHnaHumk!>xfiHi?xG>$(amDao9Ly3Vq&3lYd9&ZRcq(Tfr+E ztdmpp238X+s^smX1?o_)R&0e;`)DOzXeT0e!*gp<)o zlLD_I6iJ#NnrOj0VpITk)Lc}c9C9oW;+c!lGAIe}dl z)KV+Tu_bRZM#-1VZnHOvg8rnR{z+e|a!`9EAd?P#2|G=1(jv&173p%n7ja6ZOqI4p ztCs|#FD{waEyL}dVn4T<-+j8{XqqJO4%Ez-;?h0ey9ByhV|P-pz@k|%L-d63m&wx` z!<4XYxq4Ai$Jxqhz7)G*w-?t>gsK_)AV%$wEAKu_XN#uva+(&n38eBH+uKzTSvw~) z30jXo!z*36G1^kz%y-p_<55gHQJ~32$EPkIhT`pOc;_{IS~Zxbz_)0~G>^n3~E}wiYIj6t_*L z=&5UKQ+U|s$k8ur!GLY{jRgFlzY)k_i`}tG8;^q*ArrXR@*_K1=+V<;%QVP!L!t$Y z;Khj76=IqWa{ajHhOV_%9{PKeQ&eWVL{@=$be_f~5ZzgbHWDt^)2DwCMX1Xo#+8F7 z13r8i<4w`V9{o#=zat9lWOb+%Y#wIP!xw-oKUv(y2$nQLph&Oa1j0`X<9Z;3^i*c#2EiIR6|7&>Ms=wdAwR_)CBK<| zIT9aViWOEnl7Vd|^wZ#0T}$+A-D*Z|F;ACz$?K8K&c?e(5M(obl-FIx?T0N3?YP4t2v{}0407%zOnPubpnX4r+H?^Uf2)fy*m16Gnc#G zybnLz79X|n^u(_7_fIdpI`SzOoP5U^PVFlg@jLHyxQ1nO6$H+EUA|J|lxL&^V3PTY z1*EP2cB1l`P;1Jv3~c$&V)E?kO`9N$$?NLKOFF{jr}Eh>)|?tH)M9PzefL65bcn+U zMNddrFL>`Ht_Psrgz%rdEsxkg zbZ05a$?^Q);sF_&uFP+K^rbU%^D$@c?tK&M#t zVe{pOw_oYos%TrlS%(VOXOonVP;0~=#|MV}*eDv_=h73oliPGVp))v)O+D_vxN)&F z2V*)qx>SXm^`ty@CVGBQz!tVl&PR0)PuH4d@rUmn{ss}X+L5MKS23%rTwj(^S%JeI z5!pGF)9wr6jax3bgGPUF0gy3B&a4y5|D?RN{64 zUBwahLL%pkZwVG8IV3jf#p#VE*dMK}QHQS@>0DRKLxl7^nTs28ql9~Swa5t6QPRd0-h4NUr5qZT0PxM7hauA1? z{xPZZt%Og;2l(Pz2-M~m%%>~ENei9%Q^lg|N#P!Sr>*u^or+_pCr7Izhgu0gI;X;m zDc%mC`@;#ihN=7ASYZeuPO0y)gOB2wY11nFPI7MQz50UD&S*WGJW)-=GWTk*y@M6e zBK>E$lhD5}^Ax#tNdMe{&P@ReyyGfOdZe?KD444onR@o&*OGu+6O4+BKj*UjMn0M( zG^uQ|-TWlhlU9a%^AnDA`W|S;oW$RrxZL^ph9+JksT)t<=R{hkfw;AgR+}dz+Gr*v zUPzdZ$LqwSa!ZaZC_9~^jbWr&#v-5$c8a{~Ge*`ZP78VW@yV$iDeV{bjKB9CF%sE` z7=emtMnqDM!16>=sb^ZGR}&+jVhdNMmjiOC$xRc**b><@eKh2ru>fYgmOqJjqJZ5p zl{KT%>fbVD`PyUWYV*=4kL@B_hSNZQ3`5x4cIAGiOTwIQqh5U~6gVsWlw)MjczDFC zQzI3(-Jy_%TYle-Fea;YS{ks&?ms$Q`HXNuM-_J@ifcsYF=x>Ul4M+Zh> z(jadBn^t7%P-D~+NQDGhR5eZ7S!7H1lw-w=PjHRt9{J%Efcb9!j%d*-77`^C6d;Zr zwGY=Gn^MfII~DxKugNE$rMrgY&Z%EQ;lE~84W*0hPI+V=_HE7|cDAesA|Z_QSCz); ziMww^gKm!0uZ0?o4!PtF(UdRxGADVm#@Wi}%qri0J-8&%FX$QHAmQax zS+{-k3yB&eIB_Id@I1($wL?a!@E4507{Do;Zk8FG&763A!n%}Nr0`0F%sm33V21Kf zo_CIYKQrjLNH(Kh&r4_?dGo?I{uIbVK{TibthV(4H3->)6nFI2y`UJ1#kJ<%sCpV* z3v2QVbF1oOHp8rGUTPC#QY&RE%#~O>ThUSe%H)=;cXIhA4>3j^fv|7JBdE<%i2~#ww0| z!lMz#>H$vk674rgK^|<{%_sR11!=^%vND}gI5I;8QXT&r876Urt5 z@-El(jit;+5FjqodalhV#tN-@6Z<4cO(wpLqR-qVLmkRw<2EDsb^>_lru;y_nr+&k z-wF8=fES~sXP~ynEz`lyox6FO^+w(ft3wX$ykw+>f3jjIf@djdyY)%BJDb4S9BDz<>|L{A08H$K$Z4A#nW;Jx(RJSt)(2jJtwZ)<%#Dlu z!J{VE_UObDCW8}0VoeOqM6NfrBi7*^Q6sQFW)%@78)hT*B0j2!M3oVB5OpO*c@Y7e zRVlU939n>z0J{ns3G)p*q(_ysweOL?T!8W;0A1YXH@iDh>m0i=P4|-WujkpOJ6CLK z@-#WN{fSOrOwB<6t3RM$YL0q=&FN^LW7n^Bir_2}>`iT#jusua7}rgx*v=;X09^m^ zkc8oeX=TfLmk0M*^d_!2=)#gx6o8XX22V%_M}N)43Jea|P6#uELCirIuXXKql^Tqj zHiaY-QQ$Du&`T1L%kS_by*5jp5(8qccN`+On9flhD@#?80L_g%p0t>pz9SY~##2lY zHIc8L+ML)nqFd3?R{=`OhgN-jx@jZDUbrAZ*7yBqX&G2F3o&_cZn(x?YkGwvvg<<0 zt_Dm1)~@lVX-P0}2Hbfy`!UZMfC0iCaJ7=o)qS(OIA;?4=|&P{v2<1f*z1nqs#(Lf zxFgVSn}eoMa79W~F~Ax9Dg76lZL>gNcQWR&>Sz+n@}^PuW&tmr0Cy`?;-T_RLru>> z_JgK%fFqnft+4oC62a=9g&J2@F)QZNBSWP5QChn`TiC5p2X;H}5(q(zq{YpuX8M5g!8niZ16|)w zrQmZXFh(n36TGOCUNrkHDbzl<|Y6a zwxD7fs@gq8;oNw&Ws4~0l7oa$f$$+;fbNARXjWzPl`~2vFx8cr{(g7=IX!AR&g!O0A1bv=<#stcpzxfRxDToZQ}MMuO2?(8jF*s z)!QSO$ShOv$3Y3wDzxxcGnBbtdX3UZ#)L{mL>?cUZ2`Cyg<4#jQ7mI&aS3l1HZd3W z20HQ#2hzocO?Z^7NW?_2Lsl;x->8;v{gGya(FWWBQG#8iCBB-gHfX2q)Q-&05O<$> zTRQdbLgKehIdJk`63M~y0S>^%^Y_#a?7=s&P-Shi;+uL;BG&5&zM4?6)A1XBV?~Iz z5}x<3&LmO0ow>8*kH$REHQIMs>S_mk;ix+tQ?luDjucU&kZ1<`w4-cSHf7^d%rQTQ%$DkXe725qgG_mEQx2b?N#avg(;QBj&GS8+B-ln5L8+EF4@1# zDgmWT6g>qC6JTQ6i*hPv`F@Zy+w;bZX_G>tE`}Fc^J#vm+POPZ{OYK}uXwk`nsSw!h zB&s)uDiy+XSGBGc3*MoHzyB3w$3by4TWTv8IbLfxp= z58hQ(W9?ja1UNR4NC_(>rY*zi1lbsKq99leUYkTdxTz=kcv>C5^#*?CtBK|c+$_hn zf2Fx|v#^ELkc2IP)-AR-n^p|4hp?XP%@U|FSyzSWHgeC6x$Wh^n3xJMr#}mD_bygH z{(kwG;iWYiUJbO~PQ#_9(R)dv!>J3}N3CM95)uhV+ILcA@djg;uQ%-8 z=}|$riFWPWmx@Xr+cM%F81CEKydz~zhZI_V1_uNf_+VR&URPyh9&G2{DJKFEU9->w zO?pjtP6Mb|@7`Q*70*c1^4cf#R3Z0TR>`_&-JshY<*H!XFk|mW8<*eq@r@~ z^(L9#d#9~Vj4d5hz9xyTK4y`%{1Z57d8c*7_bzlc_$~U));+q1zC8Aatc$Yz^UCST zP%=6W|6r%~#ZP6lNvvU9lStt(O_|qy>n68#E!*R%Zl?9w%43mo#h)9XmG4DQgI-;p zh7TIc;)N29(D&PaX57w4^A?sbs7|;SOyvT^QSd;w(}VSihWd4nM!V>N&+=ifdAJ9r zbU~VtjYo_o9<3txYTpX zqyUmIrZAme-O=5N7Y)ThS6en%W1lZ#q!h2j0I%17y1}B)KrrHp)(gs|>iNIoS?A<) zc7s}oo6?g@d47#O_!6)PgQjyd7B{F9msC#Oe$OhmDTLKe$P_T!a33I@bG8|zn1 zG=8M|!J;ET6wwX1ZN~N(ke#I6HAzXMrKb(hHq+CVp^Ux6`1=^8R-u72`3)+gKQkVL zByQ4x+XvbZX))}1ImTXYV(3FV`j&}toaEq?rqeVIWc-nMiOI6-%>X;Q+5jmAqUT8L zJkzF{Ml~T0hNsmHW$2nPO}lMV2L(c#rbh1A_ymsvw;LFa34E=QpUqW-)5 zs@nlvW$ZYd7xGJ{05V0cl=bUw>@yzju4f{;Yro`4K%TTQV;=nH>MSRh&>`MbA+>1I zFS!wr8|(Avg8xnE;)$c@Wqmn1e#wEtN6!cOUD=ZPcfP!qmn6;ZOmaN?C4ZNfG@F}# zxM=#1I=n|q@9O5gY2ZBmOa5f1o7dCIGyF?Kvv<+D_X75v$NZ=9^X6#X%6F0ZzuRW3j7X(zj45CAoTw|68yU`S%*Fk6B@np3$Aim=6C!xD}F;W_4F( zOZWYP)Xo5;p6#><{sp0Bd3jSS`uP_BL%2sj0TA~8gDJ2i;>#y;{0|MD+WXf>gX<=G Jl~?aS{9mrbiPQi9 literal 0 HcmV?d00001