jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Isolate BodyFormatter exceptions

Browse Source 
Summary: If one throws an exception, we'd skip all the other ones. I don't think that's the behaviour we want.

Reviewed By: passy

Differential Revision: D12958926

fbshipit-source-id: dd82b750197b6fc1380496be4147fe63454d39da
This commit is contained in:
John Knox
2018-11-07 10:32:35 -08:00
committed by Facebook Github Bot
parent a56d7d5d72
commit bdc3abacbd
1 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/plugins/network/RequestDetails.js
View File

@@ -336,24 +336,23 @@ class RequestBodyInspector extends Component<{
const {request, formattedText} = this.props;
const bodyFormatters = formattedText ? TextBodyFormatters : BodyFormatters;
let component;
try {
for (const formatter of bodyFormatters) {
if (formatter.formatRequest) {
for (const formatter of bodyFormatters) {
if (formatter.formatRequest) {
try {
component = formatter.formatRequest(request);
if (component) {
break;
}
} catch (e) {
console.warn(
'BodyFormatter exception from ' + formatter.constructor.name,
e.getMessage(),
);
}
}
} catch (e) {}
if (component == null && request.data != null) {
component = <Text>{decodeBody(request)}</Text>;
}
if (component == null) {
return null;
}
component = component || <Text>{decodeBody(request)}</Text>;
return <BodyContainer>{component}</BodyContainer>;
}
@@ -368,16 +367,21 @@ class ResponseBodyInspector extends Component<{
const {request, response, formattedText} = this.props;
const bodyFormatters = formattedText ? TextBodyFormatters : BodyFormatters;
let component;
try {
for (const formatter of bodyFormatters) {
if (formatter.formatResponse) {
for (const formatter of bodyFormatters) {
if (formatter.formatResponse) {
try {
component = formatter.formatResponse(request, response);
if (component) {
break;
}
} catch (e) {
console.warn(
'BodyFormatter exception from ' + formatter.constructor.name,
e.getMessage(),
);
}
}
} catch (e) {}
}
component = component || <Text>{decodeBody(response)}</Text>;