jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Limit events and methods in server contact to strings only

Browse Source 
Reviewed By: antonk52

Differential Revision: D34300854

fbshipit-source-id: 79cd3e3da9bb5dbac75243ac90118f32e12d8177
This commit is contained in:
Andrey Goncharov
2022-02-28 03:50:34 -08:00
committed by Facebook GitHub Bot
parent 8b94186783
commit bdbf79e3e1
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
desktop/flipper-plugin/src/plugin/PluginBase.tsx
View File

@@ -142,7 +142,7 @@ export interface BasePluginClient<
* Messages can only arrive if the plugin is enabled and connected. * Messages can only arrive if the plugin is enabled and connected.
* For background plugins messages will be batched and arrive the next time the plugin is connected. * For background plugins messages will be batched and arrive the next time the plugin is connected.
*/ */
onServerAddOnMessage<Event extends keyof ServerAddOnEvents>( onServerAddOnMessage<Event extends keyof ServerAddOnEvents & string>(
event: Event, event: Event,
callback: (params: ServerAddOnEvents[Event]) => void, callback: (params: ServerAddOnEvents[Event]) => void,
): void; ): void;
@@ -159,7 +159,7 @@ export interface BasePluginClient<
/** /**
* Send a message to the server add-on * Send a message to the server add-on
*/ */
sendToServerAddOn<Method extends keyof ServerAddOnMethods>( sendToServerAddOn<Method extends keyof ServerAddOnMethods & string>(
method: Method, method: Method,
...params: Parameters<ServerAddOnMethods[Method]> extends [] ...params: Parameters<ServerAddOnMethods[Method]> extends []
? [] ? []
@@ -382,14 +382,13 @@ export abstract class BasePluginInstance {
sendToServerAddOn: (method, params) => sendToServerAddOn: (method, params) =>
this.serverAddOnControls.sendMessage( this.serverAddOnControls.sendMessage(
this.definition.packageName, this.definition.packageName,
// TODO: Remove type cast method,
method as string,
params, params,
), ),
onServerAddOnMessage: (event, cb) => { onServerAddOnMessage: (event, cb) => {
this.serverAddOnControls.receiveMessage( this.serverAddOnControls.receiveMessage(
this.definition.packageName, this.definition.packageName,
event as string, event,
batched(cb), batched(cb),
); );
}, },