Sandy-based plugin auto-update UI
Summary: New UX/UI for plugin auto-updates based on Sandy: - disabled plugins auto-updated silently without any notifications as there is no active state for them so there is nothing to loose. - enabled plugins can have some state and user can actually work with them, so we cannot reload them automatically. Instead, we show notification in the top of the plugin container asking user to reload the plugin when she is ready. - if the auto-updated plugin failed to reload - show error notification. - for non-sandy we continue using notifications as before. Reviewed By: mweststrate Differential Revision: D25530384 fbshipit-source-id: de3d0565ef0b930c9343b9e0ed07a4acb51885be
This commit is contained in:
committed by
Facebook GitHub Bot
parent
5383017299
commit
bd01b58566
@@ -50,6 +50,11 @@ const argv = yargs
|
||||
'[FB-internal only] Enable plugin auto-updates. The flag is disabled by default in dev mode. Env var FLIPPER_NO_PLUGIN_AUTO_UPDATE is equivalent to the command-line option "--no-plugin-auto-update"',
|
||||
type: 'boolean',
|
||||
},
|
||||
'plugin-auto-update-interval': {
|
||||
describe:
|
||||
'[FB-internal only] Set custom interval in milliseconds for plugin auto-update checks. Env var FLIPPER_PLUGIN_AUTO_UPDATE_POLLING_INTERVAL is equivalent to this command-line option.',
|
||||
type: 'number',
|
||||
},
|
||||
'enabled-plugins': {
|
||||
describe:
|
||||
'Load only specified plugins and skip loading rest. This is useful when you are developing only one or few plugins. Plugins to load can be specified as a comma-separated list with either plugin id or name used as identifier, e.g. "--enabled-plugins network,inspector". The flag is not provided by default which means that all plugins loaded.',
|
||||
@@ -115,6 +120,10 @@ if (
|
||||
process.env.FLIPPER_DISABLE_PLUGIN_AUTO_UPDATE = 'true';
|
||||
}
|
||||
|
||||
if (argv['plugin-auto-update-interval']) {
|
||||
process.env.FLIPPER_PLUGIN_AUTO_UPDATE_POLLING_INTERVAL = `${argv['plugin-auto-update-interval']}`;
|
||||
}
|
||||
|
||||
// Force participating in all GKs. Mostly intersting for Flipper team members.
|
||||
if (argv['enable-all-gks'] === true) {
|
||||
process.env.FLIPPER_ENABLE_ALL_GKS = 'true';
|
||||
|
||||
Reference in New Issue
Block a user