From bc0bdcb32fd3f4a0177a53c37e305fbda2d811cf Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Mon, 30 Jan 2023 06:33:15 -0800 Subject: [PATCH] Remove client id from error Summary: Ideally, this wouldn't fire at all as it's a timeout but removing the ID will at least allow de-duplication. Reviewed By: ivanmisuno Differential Revision: D42800581 fbshipit-source-id: 605f2e81c326a3203c72b253362cb0b27139a134 --- desktop/flipper-frontend-core/src/AbstractClient.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/desktop/flipper-frontend-core/src/AbstractClient.tsx b/desktop/flipper-frontend-core/src/AbstractClient.tsx index 85e8cb72e..ab4bf729a 100644 --- a/desktop/flipper-frontend-core/src/AbstractClient.tsx +++ b/desktop/flipper-frontend-core/src/AbstractClient.tsx @@ -129,8 +129,11 @@ export default abstract class AbstractClient extends EventEmitter { const {plugins} = await timeout( 30 * 1000, this.rawCall<{plugins: Plugins}>('getPlugins', false), - 'Fetch plugin timeout for ' + this.id, - ); + 'Fetch plugin timeout', + ).catch((e) => { + console.warn('Fetch plugin timeout for ' + this.id); + throw e; + }); this.plugins = new Set(plugins); console.info('AbstractClient.loadPlugins', this.query, plugins); return plugins;