jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix circular imports and lint against them

Browse Source 
Summary: When trying to refactor some components, did once again run into circular imports that cause the flipper startup sequence to fail. Added linting rules to make sure this is much less likely to happen in the future, and fixed all resulting errors

Reviewed By: nikoant

Differential Revision: D24390583

fbshipit-source-id: 9b20cf6a4d3555dc68f0069c2950dd7162b17e67
This commit is contained in:
Michel Weststrate
2020-10-20 03:22:15 -07:00
committed by Facebook GitHub Bot
parent f14a724fa5
commit ba5f067320
57 changed files with 108 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/app/src/utils/pluginStateRecorder.tsx
View File

@@ -175,7 +175,7 @@ function generateTestSuite(pluginName: string, snapShotFileName: string) {
import fs from 'fs';
import path from 'path';
import {deserialize} from 'flipper';
import {deserialize} from '../ui';
import Plugin from '../';
test('Verify events produce a consistent end state for plugin ${pluginName}', async () => {