Remove older support request form

Summary: This diff removes the older support form as we no longer use it.

Reviewed By: jknoxville

Differential Revision: D19769541

fbshipit-source-id: ca2088e721f2895f2c8a1205889b0670477cc2d2
This commit is contained in:
Pritesh Nandgaonkar
2020-02-07 03:43:17 -08:00
committed by Facebook Github Bot
parent 0af9065225
commit b9fafb0e61
5 changed files with 1 additions and 40 deletions

View File

@@ -47,7 +47,6 @@ import {
} from '../../reducers/connections'; } from '../../reducers/connections';
import {setActiveSheet} from '../../reducers/application'; import {setActiveSheet} from '../../reducers/application';
import {connect} from 'react-redux'; import {connect} from 'react-redux';
import SupportRequestFormManager from '../../fb-stubs/SupportRequestFormManager';
import SupportRequestDetails from '../../fb-stubs/SupportRequestDetails'; import SupportRequestDetails from '../../fb-stubs/SupportRequestDetails';
import MainSidebarUtilsSection from './MainSidebarUtilsSection'; import MainSidebarUtilsSection from './MainSidebarUtilsSection';
import { import {
@@ -209,18 +208,6 @@ class MainSidebar2 extends PureComponent<Props, State> {
showWatchDebugRoot: GK.get('watch_team_flipper_clientless_access'), showWatchDebugRoot: GK.get('watch_team_flipper_clientless_access'),
showAllPlugins: false, showAllPlugins: false,
}; };
static getDerivedStateFromProps(props: Props, state: State) {
if (
!state.showSupportForm &&
props.staticView === SupportRequestFormManager
) {
// Show SupportForm option even when GK is false and support form is shown.
// That means the user has used deeplink to open support form.
// Once the variable is true, it will be true for the whole session.
return {showSupportForm: true};
}
return state;
}
render() { render() {
const {devices} = this.props; const {devices} = this.props;

View File

@@ -19,7 +19,6 @@ import NotificationScreen from '../NotificationScreen';
import {StaticView, setStaticView} from '../../reducers/connections'; import {StaticView, setStaticView} from '../../reducers/connections';
import {setActiveSheet} from '../../reducers/application'; import {setActiveSheet} from '../../reducers/application';
import UserAccount from '../UserAccount'; import UserAccount from '../UserAccount';
import SupportRequestFormManager from '../../fb-stubs/SupportRequestFormManager';
import SupportRequestFormV2 from '../../fb-stubs/SupportRequestFormV2'; import SupportRequestFormV2 from '../../fb-stubs/SupportRequestFormV2';
import WatchTools from '../../fb-stubs/WatchTools'; import WatchTools from '../../fb-stubs/WatchTools';
import { import {
@@ -55,9 +54,7 @@ function MainSidebarUtilsSection({
const hasSeenSupportForm = useRef(false); const hasSeenSupportForm = useRef(false);
const showSupportForm = const showSupportForm =
GK.get('support_requests_v2') || GK.get('support_requests_v2') || hasSeenSupportForm.current;
isStaticViewActive(staticView, SupportRequestFormManager) ||
hasSeenSupportForm.current;
if (showSupportForm) { if (showSupportForm) {
hasSeenSupportForm.current = true; hasSeenSupportForm.current = true;
} }

View File

@@ -1,20 +0,0 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
*/
import Text from '../ui/components/FlexRow';
import React, {PureComponent} from 'react';
export default class SupportRequestFormManager extends PureComponent<
void,
void
> {
render() {
return <Text> Implement your own Bug creator </Text>;
}
}

View File

@@ -29,7 +29,6 @@ export {PluginClient, Props} from './plugin';
export {default as Client} from './Client'; export {default as Client} from './Client';
export {MetricType} from './utils/exportMetrics'; export {MetricType} from './utils/exportMetrics';
export {clipboard} from 'electron'; export {clipboard} from 'electron';
export {default as SupportRequestFormManager} from './fb-stubs/SupportRequestFormManager';
export {default as SupportRequestFormV2} from './fb-stubs/SupportRequestFormV2'; export {default as SupportRequestFormV2} from './fb-stubs/SupportRequestFormV2';
export {default as constants} from './fb-stubs/constants'; export {default as constants} from './fb-stubs/constants';
export {connect} from 'react-redux'; export {connect} from 'react-redux';

View File

@@ -22,7 +22,6 @@ const WelcomeScreen = isHeadless()
? require('../chrome/WelcomeScreenHeadless').default ? require('../chrome/WelcomeScreenHeadless').default
: require('../chrome/WelcomeScreen').default; : require('../chrome/WelcomeScreen').default;
import NotificationScreen from '../chrome/NotificationScreen'; import NotificationScreen from '../chrome/NotificationScreen';
import SupportRequestForm from '../fb-stubs/SupportRequestFormManager';
import SupportRequestFormV2 from '../fb-stubs/SupportRequestFormV2'; import SupportRequestFormV2 from '../fb-stubs/SupportRequestFormV2';
import SupportRequestDetails from '../fb-stubs/SupportRequestDetails'; import SupportRequestDetails from '../fb-stubs/SupportRequestDetails';
import {getPluginKey} from '../utils/pluginUtils'; import {getPluginKey} from '../utils/pluginUtils';
@@ -34,7 +33,6 @@ export type StaticView =
| null | null
| typeof WelcomeScreen | typeof WelcomeScreen
| typeof NotificationScreen | typeof NotificationScreen
| typeof SupportRequestForm
| typeof SupportRequestFormV2 | typeof SupportRequestFormV2
| typeof SupportRequestDetails; | typeof SupportRequestDetails;