jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add archived device type

Browse Source 
Summary:
This diff adds archived device type. This diff solves the following two problems.

- The Plugin which are device plugins and are device plugins will not show up. Look at the video, where the CPU plugin was showed, even though the imported file didn't have any information.
- An icon of 📦 will make much clearer which one is archived device and which isn't

Reviewed By: passy

Differential Revision: D14066399

fbshipit-source-id: 59b740d7fe9532e665d6b1ec6ad0124fb63ac45d
This commit is contained in:
Pritesh Nandgaonkar
2019-02-14 06:28:53 -08:00
committed by Facebook Github Bot
parent 9b6db1f482
commit b9db2411cf
5 changed files with 53 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/utils/__tests__/exportData.electron.js
View File

@@ -73,8 +73,8 @@ test('test generateClientIndentifierWithSalt helper function', () => {
);
const identifier = generateClientIdentifier(device, 'app');
const saltIdentifier = generateClientIdentifierWithSalt(identifier, 'salt');
expect(saltIdentifier).toEqual('app#iOS#emulator#salt-serial');
expect(identifier).toEqual('app#iOS#emulator#serial');
expect(saltIdentifier).toEqual('app#iOS#archivedEmulator#salt-serial');
expect(identifier).toEqual('app#iOS#archivedEmulator#serial');
});
test('test generateClientFromClientWithSalt helper function', () => {
@@ -88,20 +88,20 @@ test('test generateClientFromClientWithSalt helper function', () => {
const client = generateClientFromDevice(device, 'app');
const saltedClient = generateClientFromClientWithSalt(client, 'salt');
expect(saltedClient).toEqual({
id: 'app#iOS#emulator#salt-serial',
id: 'app#iOS#archivedEmulator#salt-serial',
query: {
app: 'app',
os: 'iOS',
device: 'emulator',
device: 'archivedEmulator',
device_id: 'salt-serial',
},
});
expect(client).toEqual({
id: 'app#iOS#emulator#serial',
id: 'app#iOS#archivedEmulator#serial',
query: {
app: 'app',
os: 'iOS',
device: 'emulator',
device: 'archivedEmulator',
device_id: 'serial',
},
});
@@ -117,11 +117,11 @@ test('test generateClientFromDevice helper function', () => {
);
const client = generateClientFromDevice(device, 'app');
expect(client).toEqual({
id: 'app#iOS#emulator#serial',
id: 'app#iOS#archivedEmulator#serial',
query: {
app: 'app',
os: 'iOS',
device: 'emulator',
device: 'archivedEmulator',
device_id: 'serial',
},
});
@@ -136,7 +136,7 @@ test('test generateClientIdentifier helper function', () => {
[],
);
const identifier = generateClientIdentifier(device, 'app');
expect(identifier).toEqual('app#iOS#emulator#serial');
expect(identifier).toEqual('app#iOS#archivedEmulator#serial');
});
test('test generateNotifications helper function', () => {
@@ -171,7 +171,7 @@ test('test processStore function for an iOS device connected', () => {
//$FlowFixMe Flow doesn't that its a test and the assertion for null is already done
const {serial, deviceType, title, os} = device;
expect(serial).toEqual('salt-serial');
expect(deviceType).toEqual('emulator');
expect(deviceType).toEqual('archivedEmulator');
expect(title).toEqual('TestiPhone');
expect(os).toEqual('iOS');
//$FlowFixMe Flow doesn't that its a test and the assertion for null is already done