From b94f6b61529dea0f2879c1572b53fc812e7af688 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Wed, 10 May 2023 04:35:17 -0700 Subject: [PATCH] Set the right environment info for headless builds Summary: The isHeadlessBuild flag was not properly set. Reviewed By: antonk52 Differential Revision: D45728435 fbshipit-source-id: 3616c4358114d4f3d96372766dabf48b27b44333 --- desktop/app/src/init.tsx | 1 + .../flipper-server-core/src/server/startFlipperServer.tsx | 7 ++++++- desktop/flipper-server/src/index.tsx | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/desktop/app/src/init.tsx b/desktop/app/src/init.tsx index c56712595..6578d06d7 100644 --- a/desktop/app/src/init.tsx +++ b/desktop/app/src/init.tsx @@ -182,6 +182,7 @@ async function getFlipperServer( false, keytar, 'embedded', + environmentInfo.isHeadlessBuild, ); const companionEnv = await initCompanionEnv(server); diff --git a/desktop/flipper-server-core/src/server/startFlipperServer.tsx b/desktop/flipper-server-core/src/server/startFlipperServer.tsx index ce92bf0f2..e687d761f 100644 --- a/desktop/flipper-server-core/src/server/startFlipperServer.tsx +++ b/desktop/flipper-server-core/src/server/startFlipperServer.tsx @@ -39,6 +39,7 @@ export async function startFlipperServer( enableLauncherSettings: boolean, keytarModule: KeytarModule, type: FlipperServerType, + isHeadless: boolean, ): Promise { const execPath = process.execPath; const appPath = rootDir; @@ -53,7 +54,11 @@ export async function startFlipperServer( desktopPath = os.homedir(); } - const environmentInfo = await getEnvironmentInfo(appPath, isProduction, true); + const environmentInfo = await getEnvironmentInfo( + appPath, + isProduction, + isHeadless, + ); return new FlipperServerImpl( { diff --git a/desktop/flipper-server/src/index.tsx b/desktop/flipper-server/src/index.tsx index e06b3f980..bd13d5f0a 100644 --- a/desktop/flipper-server/src/index.tsx +++ b/desktop/flipper-server/src/index.tsx @@ -117,6 +117,7 @@ async function start() { argv.launcherSettings, keytar, 'external', + true, ); exitHook(async () => {