From b8e6298df50e848b49d54326f0eaad6cd5ce3ccf Mon Sep 17 00:00:00 2001
From: Manish Singhal <manishsnghl@fb.com>
Date: Tue, 26 Feb 2019 15:58:26 -0800
Subject: [PATCH] Added support for cold start in image perf plugin

Summary:
This diff adds support for cold start in image perf plugin. Now developer can see which images have been requested as part of cold start.

CC: Diego Sanchez Vivian Wehner Alexander Oprisnik Gaurav Nijhara

Reviewed By: jknoxville

Differential Revision: D14227065

fbshipit-source-id: 3347b460e491b218115d8572cb8b323de909ef1b
---
 src/plugins/fresco/ImagesSidebar.js | 9 +++++++++
 src/plugins/fresco/api.js           | 1 +
 2 files changed, 10 insertions(+)

diff --git a/src/plugins/fresco/ImagesSidebar.js b/src/plugins/fresco/ImagesSidebar.js
index 20b47c6cb..0c20dc72c 100644
--- a/src/plugins/fresco/ImagesSidebar.js
+++ b/src/plugins/fresco/ImagesSidebar.js
@@ -112,6 +112,15 @@ class EventDetails extends Component<{
             setValue={function(path: Array<string>, val: any) {}}
           />
         </p>
+        <p>
+          <DataDescriptionKey>Requested on cold start</DataDescriptionKey>
+          <span key="sep">: </span>
+          <DataDescription
+            type="number"
+            value={event.coldStart}
+            setValue={function(path: Array<string>, val: any) {}}
+          />
+        </p>
         {this.renderViewportData()}
       </EventDetails.Container>
     );
diff --git a/src/plugins/fresco/api.js b/src/plugins/fresco/api.js
index dcfbb79e0..3500e66fd 100644
--- a/src/plugins/fresco/api.js
+++ b/src/plugins/fresco/api.js
@@ -58,6 +58,7 @@ export type ImageEvent = {
   startTime: Timestamp,
   endTime: Timestamp,
   source: string,
+  coldStart: number,
   viewport?: ViewportData, // not set for prefetches
 };