From b7fff237004fc226c0f229f30af4c446bb031c49 Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Wed, 1 May 2019 08:32:56 -0700 Subject: [PATCH] Move example plugin out of core Summary: We should not ship this as part of our distribution. Just meant we had to bifurcate our unit tests which is a bit awkward, but it works now. Reviewed By: jknoxville Differential Revision: D15146980 fbshipit-source-id: 496b000630bbfcaa663cddacb00550e1499a1279 --- android/sample/build.gradle | 12 ++++++++++++ .../plugins/example/ExampleFlipperPlugin.java | 0 .../plugins/example/ExampleFlipperPluginTest.java | 2 ++ .../flipper/plugins/example/TestApplication.java | 12 ++++++++++++ 4 files changed, 26 insertions(+) rename android/{ => sample}/src/main/java/com/facebook/flipper/plugins/example/ExampleFlipperPlugin.java (100%) rename android/{ => sample}/src/test/java/com/facebook/flipper/plugins/example/ExampleFlipperPluginTest.java (93%) create mode 100644 android/sample/src/test/java/com/facebook/flipper/plugins/example/TestApplication.java diff --git a/android/sample/build.gradle b/android/sample/build.gradle index e8965d79f..2912416cd 100644 --- a/android/sample/build.gradle +++ b/android/sample/build.gradle @@ -23,6 +23,12 @@ android { main { manifest.srcFile './AndroidManifest.xml' } + + test { + java { + exclude 'com/facebook/flipper/plugins/facebook/**' + } + } } compileOptions { @@ -52,5 +58,11 @@ dependencies { androidTestImplementation deps.testCore androidTestImplementation deps.testRules + // Unit tests + testImplementation deps.mockito + testImplementation deps.robolectric + testImplementation deps.hamcrest + testImplementation deps.junit + implementation project(':android') } diff --git a/android/src/main/java/com/facebook/flipper/plugins/example/ExampleFlipperPlugin.java b/android/sample/src/main/java/com/facebook/flipper/plugins/example/ExampleFlipperPlugin.java similarity index 100% rename from android/src/main/java/com/facebook/flipper/plugins/example/ExampleFlipperPlugin.java rename to android/sample/src/main/java/com/facebook/flipper/plugins/example/ExampleFlipperPlugin.java diff --git a/android/src/test/java/com/facebook/flipper/plugins/example/ExampleFlipperPluginTest.java b/android/sample/src/test/java/com/facebook/flipper/plugins/example/ExampleFlipperPluginTest.java similarity index 93% rename from android/src/test/java/com/facebook/flipper/plugins/example/ExampleFlipperPluginTest.java rename to android/sample/src/test/java/com/facebook/flipper/plugins/example/ExampleFlipperPluginTest.java index c8822335e..bed66aea0 100644 --- a/android/src/test/java/com/facebook/flipper/plugins/example/ExampleFlipperPluginTest.java +++ b/android/sample/src/test/java/com/facebook/flipper/plugins/example/ExampleFlipperPluginTest.java @@ -16,8 +16,10 @@ import com.facebook.flipper.testing.FlipperResponderMock; import org.junit.Test; import org.junit.runner.RunWith; import org.robolectric.RobolectricTestRunner; +import org.robolectric.annotation.Config; @RunWith(RobolectricTestRunner.class) +@Config(application = TestApplication.class) public class ExampleFlipperPluginTest { @Test diff --git a/android/sample/src/test/java/com/facebook/flipper/plugins/example/TestApplication.java b/android/sample/src/test/java/com/facebook/flipper/plugins/example/TestApplication.java new file mode 100644 index 000000000..d7dd43390 --- /dev/null +++ b/android/sample/src/test/java/com/facebook/flipper/plugins/example/TestApplication.java @@ -0,0 +1,12 @@ +/* + * Copyright (c) 2018-present, Facebook, Inc. + * + * This source code is licensed under the MIT license found in the LICENSE + * file in the root directory of this source tree. + * + */ +package com.facebook.flipper.plugins.example; + +import android.app.Application; + +public class TestApplication extends Application {}