From b7c38556cedcdbc03b965e5726e7cb3cbfdb94da Mon Sep 17 00:00:00 2001 From: Marcelo Lopez Ruiz Date: Wed, 10 Aug 2022 21:21:39 -0700 Subject: [PATCH] Name the Flipper scheduler/threads Summary: Plumbs through an optional name for FollyScopedThreadScheduler. This allows the threads to be named in XCode/lldb. Differential Revision: D38582449 fbshipit-source-id: 1de50d25c0f91e7003cf81cb22faf4b10a8e23a8 --- iOS/FlipperKit/FlipperClient.mm | 6 ++++-- xplat/Flipper/FlipperFollyScopedThreadScheduler.h | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/iOS/FlipperKit/FlipperClient.mm b/iOS/FlipperKit/FlipperClient.mm index 17ffd172e..10e6ec70e 100644 --- a/iOS/FlipperKit/FlipperClient.mm +++ b/iOS/FlipperKit/FlipperClient.mm @@ -91,9 +91,11 @@ using WrapperPlugin = facebook::flipper::FlipperCppWrapperPlugin; #endif sonarScheduler = - std::make_unique(); + std::make_unique( + "Flipper.sonar"); connectionScheduler = - std::make_unique(); + std::make_unique( + "Flipper.connection"); static const std::string UNKNOWN = std::string("unknown"); try { facebook::flipper::FlipperClient::init( diff --git a/xplat/Flipper/FlipperFollyScopedThreadScheduler.h b/xplat/Flipper/FlipperFollyScopedThreadScheduler.h index 7fc8b5b44..b94a68a4b 100644 --- a/xplat/Flipper/FlipperFollyScopedThreadScheduler.h +++ b/xplat/Flipper/FlipperFollyScopedThreadScheduler.h @@ -17,6 +17,10 @@ namespace facebook { namespace flipper { struct FollyScopedThreadScheduler : public Scheduler { + FollyScopedThreadScheduler() : FollyScopedThreadScheduler("") {} + FollyScopedThreadScheduler(folly::StringPiece name) + : thread_(nullptr, name) {} + virtual void schedule(Func&& t) override { thread_.getEventBase()->add(t); }