Fix disconnect during init logging
Summary: When a client disconnects while it's still initialising, we get a critical error. But this is expected to happen now and again, so adding a specific error for it, and handling it accordingly. It doesn't change the control flow, just the logging. Reviewed By: nikoant Differential Revision: D32794062 fbshipit-source-id: cf27fb9c345aa6369d338838a46e75a6b7afde41
This commit is contained in:
committed by
Facebook GitHub Bot
parent
9fc1d3cfb9
commit
b7a29ac0b3
@@ -15,7 +15,10 @@ import BaseDevice from './devices/BaseDevice';
|
||||
import {Logger} from 'flipper-common';
|
||||
import {Store} from './reducers/index';
|
||||
import {performance} from 'perf_hooks';
|
||||
import {reportPluginFailures} from 'flipper-common';
|
||||
import {
|
||||
reportPluginFailures,
|
||||
NoLongerConnectedToClientError,
|
||||
} from 'flipper-common';
|
||||
import {default as isProduction} from './utils/isProduction';
|
||||
import {EventEmitter} from 'events';
|
||||
import invariant from 'invariant';
|
||||
@@ -509,7 +512,7 @@ export default class Client extends EventEmitter {
|
||||
key: 'appnotconnectedwarning',
|
||||
duration: 0.5,
|
||||
});
|
||||
reject(new Error('Not connected to client'));
|
||||
reject(new NoLongerConnectedToClientError());
|
||||
return;
|
||||
}
|
||||
if (!fromPlugin || this.isAcceptingMessagesFromPlugin(plugin)) {
|
||||
|
||||
Reference in New Issue
Block a user