jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make onRegisterDevice strict

Browse Source 
Summary: Needed relaxing some types in pluginUtils, but it's actually fine.

Reviewed By: danielbuechele

Differential Revision: D17072974

fbshipit-source-id: c3d3923ed70f71964aa10cf35f1b9ea2f30a8fa1
This commit is contained in:
Pascal Hartig
2019-08-28 03:00:15 -07:00
committed by Facebook Github Bot
parent 5cac2edc37
commit b6df5ecb83
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/utils/onRegisterDevice.tsx
View File

@@ -5,7 +5,7 @@
* @format * @format
*/ */
import {Store} from '../reducers/index'; import {Store} from '../reducers/index';
import {FlipperPlugin, FlipperDevicePlugin} from '../plugin'; import {FlipperPlugin, FlipperDevicePlugin, FlipperBasePlugin} from '../plugin';
import {setPluginState} from '../reducers/pluginStates'; import {setPluginState} from '../reducers/pluginStates';
import BaseDevice from '../devices/BaseDevice'; import BaseDevice from '../devices/BaseDevice';
import {getPersistedState} from '../utils/pluginUtils'; import {getPersistedState} from '../utils/pluginUtils';
@@ -16,7 +16,7 @@ export function registerDeviceCallbackOnPlugins(
clientPlugins: Map<string, typeof FlipperPlugin>, clientPlugins: Map<string, typeof FlipperPlugin>,
device: BaseDevice, device: BaseDevice,
) { ) {
const callRegisterDeviceHook = plugin => { const callRegisterDeviceHook = (plugin: typeof FlipperBasePlugin) => {
if (plugin.onRegisterDevice) { if (plugin.onRegisterDevice) {
plugin.onRegisterDevice( plugin.onRegisterDevice(
store, store,

4
src/utils/pluginUtils.tsx
View File

@@ -4,7 +4,7 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
* @format * @format
*/ */
import {FlipperDevicePlugin, FlipperPlugin} from '../plugin'; import {FlipperDevicePlugin, FlipperPlugin, FlipperBasePlugin} from '../plugin';
import BaseDevice from '../devices/BaseDevice'; import BaseDevice from '../devices/BaseDevice';
import {State as PluginStatesState} from '../reducers/pluginStates'; import {State as PluginStatesState} from '../reducers/pluginStates';
import {pluginsClassMap} from './exportData'; import {pluginsClassMap} from './exportData';
@@ -28,7 +28,7 @@ export function getPluginKey(
export function getPersistedState<PersistedState>( export function getPersistedState<PersistedState>(
pluginKey: string, pluginKey: string,
persistingPlugin: typeof FlipperPlugin | typeof FlipperDevicePlugin | null, persistingPlugin: typeof FlipperBasePlugin | null,
pluginStates: PluginStatesState, pluginStates: PluginStatesState,
): PersistedState | null { ): PersistedState | null {
if (!persistingPlugin) { if (!persistingPlugin) {