Fix startLogging / stopLogging for ArchivedDevice
Summary: Unit test would fail on trying to emit server commands when creating a ArchivedDevice. But archived devices can silently ignore log start commands, which fixes the failing test as well. Example failing run: https://github.com/facebook/flipper/runs/3685776120 I'm not sure why the test wasn't _always_ failing Reviewed By: lblasa Differential Revision: D31142584 fbshipit-source-id: 57106ecdace9f72444eaf68ee9fa024c84556a1c
This commit is contained in:
committed by
Facebook GitHub Bot
parent
987755bb09
commit
b539f4d870
@@ -68,4 +68,18 @@ export default class ArchivedDevice extends BaseDevice {
|
||||
getArchivedScreenshotHandle(): string | null {
|
||||
return this.archivedScreenshotHandle;
|
||||
}
|
||||
|
||||
/**
|
||||
* @override
|
||||
*/
|
||||
async startLogging() {
|
||||
// No-op
|
||||
}
|
||||
|
||||
/**
|
||||
* @override
|
||||
*/
|
||||
async stopLogging() {
|
||||
// No-op
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user