From b3f9bd9ee1aaab1c4c6a668d3dfb3596b61c5c3a Mon Sep 17 00:00:00 2001
From: John Knox <jknox@fb.com>
Date: Wed, 31 Oct 2018 08:52:50 -0700
Subject: [PATCH] Remove adb reverse from test setup

Summary:
The bash file was running adb reverse on the oneworld devices.

Switching to use the real code to do this instead.

--forceExit is needed because the dispatcher keeps an open handle on the adb connection, and it doesn't expose a close() method to stop it. I'm not sure of the best way to fix that, but it's out of scope for this diff anyway.

Reviewed By: passy

Differential Revision: D10868563

fbshipit-source-id: fb44ff1353d5050bb7967cb6c4fa18c2e5d0d149
---
 package.json                   | 2 +-
 src/__tests__/server.device.js | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/package.json b/package.json
index da7cb6cec..57401690e 100644
--- a/package.json
+++ b/package.json
@@ -102,7 +102,7 @@
     "fix": "eslint . --fix",
     "test": "jest --testPathPattern=node\\.js$ --no-cache",
     "test-electron": "jest --testPathPattern=electron\\.js$ --testEnvironment=@jest-runner/electron/environment --runner=@jest-runner/electron --no-cache",
-    "test-with-device": "USE_ELECTRON_STUBS=1 jest --testPathPattern=device\\.js$ --detectOpenHandles --no-cache",
+    "test-with-device": "USE_ELECTRON_STUBS=1 jest --testPathPattern=device\\.js$ --detectOpenHandles --forceExit --no-cache",
     "lint": "eslint . && flow check"
   },
   "optionalDependencies": {
diff --git a/src/__tests__/server.device.js b/src/__tests__/server.device.js
index eb148cc32..83312ec67 100644
--- a/src/__tests__/server.device.js
+++ b/src/__tests__/server.device.js
@@ -12,6 +12,7 @@ import configureStore from 'redux-mock-store';
 import path from 'path';
 import os from 'os';
 import fs from 'fs';
+import androidDevice from '../dispatcher/androidDevice';
 
 let server;
 const mockStore = configureStore([])(reducers(undefined, {type: 'INIT'}));
@@ -23,7 +24,12 @@ beforeAll(() => {
     fs.mkdirSync(flipperDir);
   }
 
-  server = new Server(new LogManager(), mockStore);
+  const logger = new LogManager();
+
+  // Set up android dispatcher, which does the adb reversing.
+  androidDevice(mockStore, logger);
+
+  server = new Server(logger, mockStore);
   return server.init();
 });