jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the scroll of the crash headers in the plugin

Browse Source 
Summary:
When the text is too long either for the crash name and the crash reason, user is not able to see scroll and see the text.

Bug:

{F162636692}

Reviewed By: danielbuechele

Differential Revision: D15907908

fbshipit-source-id: a9557074e310728d4cb4825ec18740ca0ea0c12f
This commit is contained in:
Pritesh Nandgaonkar
2019-06-20 06:12:42 -07:00
committed by Facebook Github Bot
parent 0f9845a647
commit b3979e7012
1 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/plugins/crash_reporter/index.js
View File

@@ -104,7 +104,7 @@ const Line = styled(View)({
}); });
const Container = styled(FlexColumn)({ const Container = styled(FlexColumn)({
overflow: 'hidden', overflow: 'scroll',
flexShrink: 0, flexShrink: 0,
}); });
@@ -115,7 +115,9 @@ const Value = styled(Text)({
maxHeight: 200, maxHeight: 200,
flexGrow: 1, flexGrow: 1,
textOverflow: 'ellipsis', textOverflow: 'ellipsis',
marginLeft: 8,
marginRight: 8, marginRight: 8,
overflow: 'hidden',
}); });
const FlexGrowColumn = styled(FlexColumn)({ const FlexGrowColumn = styled(FlexColumn)({
@@ -458,24 +460,22 @@ class HeaderRow extends Component<HeaderRowProps> {
render() { render() {
const {title, value} = this.props; const {title, value} = this.props;
return ( return (
<Padder paddingTop={8} paddingBottom={2}> <Padder paddingTop={8} paddingBottom={2} paddingLeft={8}>
<Container> <Container>
<Padder paddingLeft={8}> <FlexRow>
<FlexRow> <Title>{title}</Title>
<Title>{title}</Title> <ContextMenu
<ContextMenu items={[
items={[ {
{ label: 'copy',
label: 'copy', click: () => {
click: () => { clipboard.writeText(value);
clipboard.writeText(value);
},
}, },
]}> },
<Value code={true}>{value}</Value> ]}>
</ContextMenu> <Value code={true}>{value}</Value>
</FlexRow> </ContextMenu>
</Padder> </FlexRow>
<Line /> <Line />
</Container> </Container>
</Padder> </Padder>