jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make isLoggedIn report user value instead of bool

Browse Source 
Summary: It makes little sense to hide this info from developers. It was also requested by antonk52

Reviewed By: LukeDefeo

Differential Revision: D44631235

fbshipit-source-id: 1756c5ca2a95b2f815f8c4336621d3c057b704f2
This commit is contained in:
Andrey Goncharov
2023-04-04 05:26:31 -07:00
committed by Facebook GitHub Bot
parent 7edaf24d5c
commit b3307baafe
6 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/flipper-ui-core/src/dispatcher/pluginMarketplace.tsx
View File

@@ -24,7 +24,7 @@ import isPluginCompatible from '../utils/isPluginCompatible';
import {selectCompatibleMarketplaceVersions} from './plugins';
import isPluginVersionMoreRecent from '../utils/isPluginVersionMoreRecent';
import {isConnectivityOrAuthError} from 'flipper-common';
import {isLoggedIn} from '../fb-stubs/user';
import {currentUser} from '../fb-stubs/user';
import {getRenderHostInstance} from 'flipper-frontend-core';
// TODO: provide this value from settings
@@ -43,7 +43,7 @@ function isAutoUpdateDisabled(store: Store) {
(!getFlipperLib().isFB &&
!store.getState().settingsState.enablePluginMarketplaceAutoUpdate) ||
// for internal build we disable auto-updates in case user is not logged
(getFlipperLib().isFB && !isLoggedIn().get()) ||
(getFlipperLib().isFB && !currentUser().get()) ||
getRenderHostInstance().GK('flipper_disable_plugin_auto_update') ||
getRenderHostInstance().serverConfig.env.FLIPPER_NO_PLUGIN_AUTO_UPDATE !==
undefined
@@ -113,7 +113,7 @@ export async function loadPluginsFromMarketplace(
}
async function refreshMarketplacePlugins(store: Store): Promise<void> {
if (getFlipperLib().isFB && !isLoggedIn().get()) {
if (getFlipperLib().isFB && !currentUser().get()) {
// inside FB we cannot refresh when user is not logged
return;
}