From b25de27b8a87e7b33d216fc17896465ce471c33e Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Thu, 18 Feb 2021 09:29:24 -0800 Subject: [PATCH] Move bolts dependencies to Fresco plugin (#1937) Summary: Fixes https://github.com/facebook/flipper/issues/1919 Somehow the diff author put the dependencies in the root `build.gradle`, which is unnecessary as this is only used by Fresco. Pull Request resolved: https://github.com/facebook/flipper/pull/1937 Test Plan: Built the sample app, checked that the Fresco stuff continues to work. ![Screenshot_1613565381](https://user-images.githubusercontent.com/9906/108205459-0366ef80-711d-11eb-8b3b-f804f02622af.png) Reviewed By: mweststrate Differential Revision: D26483701 Pulled By: passy fbshipit-source-id: 88f056ed0897f2c00844e02721eb45d5b85c6908 --- android/build.gradle | 3 --- android/plugins/fresco/build.gradle | 3 +++ build.gradle | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index e458edcc7..aeaf1a7f8 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -74,9 +74,6 @@ android { testImplementation deps.testRules testImplementation deps.hamcrest testImplementation deps.junit - - api 'com.parse.bolts:bolts-tasks:1.4.0' - api 'com.parse.bolts:bolts-applinks:1.4.0' } } diff --git a/android/plugins/fresco/build.gradle b/android/plugins/fresco/build.gradle index f949f673b..e8bac6520 100644 --- a/android/plugins/fresco/build.gradle +++ b/android/plugins/fresco/build.gradle @@ -23,6 +23,9 @@ android { implementation deps.frescoFlipper compileOnly deps.jsr305 + api deps.boltsTasks + api deps.boltsApplinks + // Exclude the actual stetho dep as we only want some of the fresco APIs here implementation(deps.frescoStetho) { exclude group: 'com.facebook.stetho' diff --git a/build.gradle b/build.gradle index db90f1889..673a0eb17 100644 --- a/build.gradle +++ b/build.gradle @@ -73,6 +73,8 @@ ext.deps = [ // First-party soloader : 'com.facebook.soloader:soloader:0.10.1', screenshot : 'com.facebook.testing.screenshot:core:0.5.0', + boltsTasks : 'com.parse.bolts:bolts-tasks:1.4.0', + boltsApplinks : 'com.parse.bolts:bolts-applinks:1.4.0', // Annotations jsr305 : 'com.google.code.findbugs:jsr305:3.0.2', inferAnnotations : 'com.facebook.infer.annotation:infer-annotation:0.11.2',