From b185cabbc2802f25599cec9463182b7f788f74da Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Mon, 23 May 2022 11:25:33 -0700 Subject: [PATCH] Fix height of launch emu window Summary: A paper cut that hurt me so many times. The launch emulator window gets populated by external commands that finish at interminate points in time and change the size, jiggling the buttons around. That means, you may hover over an android emulator just when the iOS command returns and when you click, you don't hit the Android emu, but some iOS thing. This just makes the height fixed, so this cannot happen. Still having some more improvements in mind as this is such a high-trafficked surface. Chanlog: Fix wiggling of the Launch Emulator dialogue as data comes in Reviewed By: mweststrate Differential Revision: D36595001 fbshipit-source-id: e61de55f348ab4d2f6f977552539d2a44d3fd11d --- .../src/sandy-chrome/appinspect/LaunchEmulator.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop/flipper-ui-core/src/sandy-chrome/appinspect/LaunchEmulator.tsx b/desktop/flipper-ui-core/src/sandy-chrome/appinspect/LaunchEmulator.tsx index 75994fdb9..ffbcefbfb 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/appinspect/LaunchEmulator.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/appinspect/LaunchEmulator.tsx @@ -143,7 +143,7 @@ export const LaunchEmulatorDialog = withTrackingScope( onCancel={onClose} title="Launch Emulator" footer={null} - bodyStyle={{maxHeight: 400, overflow: 'auto'}}> + bodyStyle={{maxHeight: 400, height: 400, overflow: 'auto'}}> {items.length ? items : }