jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Babel transformations refactoring

Browse Source 
Summary: Just a small refactoring to only create array with plugins once. This should make transformations a bit faster as all these methods are called many times for each file in the project.

Reviewed By: passy

Differential Revision: D21308498

fbshipit-source-id: 0ed47f13cebfebd2992817caa207dc55f1dbeb0a
This commit is contained in:
Anton Nikolaev
2020-04-30 04:25:28 -07:00
committed by Facebook GitHub Bot
parent c21ccedf14
commit b0a0b0f355
6 changed files with 101 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
desktop/babel-transformer/src/transform.ts
View File

@@ -8,11 +8,56 @@
*/
import {default as generate} from '@babel/generator';
import {parse} from '@babel/parser';
import {parse, ParserPlugin} from '@babel/parser';
import {transformFromAstSync} from '@babel/core';
import {default as flipperEnv} from './flipper-env';
import {resolve} from 'path';
const jsParsePlugins: ParserPlugin[] = [
'jsx',
['flow', {all: true}],
'classProperties',
'objectRestSpread',
'optionalChaining',
'nullishCoalescingOperator',
];
const tsParsePluins: ParserPlugin[] = [
'jsx',
'typescript',
'classProperties',
'optionalChaining',
'nullishCoalescingOperator',
];
const commonJsPlugin = [
require('@babel/plugin-transform-modules-commonjs'),
{
strictMode: false,
},
];
const classPropertiesPlugin = require('@babel/plugin-proposal-class-properties');
const optionalChainingPlugin = require('@babel/plugin-proposal-optional-chaining');
const coalescingOperatorPlugin = require('@babel/plugin-proposal-nullish-coalescing-operator');
const objectRestSpreadPlugin = require('@babel/plugin-proposal-object-rest-spread');
const flowStripTypesPlugin = require('@babel/plugin-transform-flow-strip-types');
const dynamicRequiresPlugin = require('./dynamic-requires');
const typeScriptPlugin = require('@babel/plugin-transform-typescript');
const tsTransformPlugins = [
typeScriptPlugin,
classPropertiesPlugin,
commonJsPlugin,
optionalChainingPlugin,
coalescingOperatorPlugin,
];
const jsTransformPlugins = [
commonJsPlugin,
objectRestSpreadPlugin,
classPropertiesPlugin,
flowStripTypesPlugin,
optionalChainingPlugin,
coalescingOperatorPlugin,
dynamicRequiresPlugin,
];
export default function transform({
filename,
options,
@@ -30,49 +75,9 @@ export default function transform({
presets = presets ?? [require('@babel/preset-react')];
plugins = plugins ?? [];
const isTypeScript = filename.endsWith('.tsx') || filename.endsWith('.ts');
const commonJs = [
require('@babel/plugin-transform-modules-commonjs'),
{
strictMode: false,
},
];
if (!isTypeScript) {
plugins.unshift(
commonJs,
require('@babel/plugin-proposal-object-rest-spread'),
require('@babel/plugin-proposal-class-properties'),
require('@babel/plugin-transform-flow-strip-types'),
require('@babel/plugin-proposal-optional-chaining'),
require('@babel/plugin-proposal-nullish-coalescing-operator'),
require('./dynamic-requires'),
);
} else {
plugins.unshift(
require('@babel/plugin-transform-typescript'),
require('@babel/plugin-proposal-class-properties'),
commonJs,
require('@babel/plugin-proposal-optional-chaining'),
require('@babel/plugin-proposal-nullish-coalescing-operator'),
);
}
const ast = parse(src, {
sourceFilename: filename,
plugins: isTypeScript
? [
'jsx',
'typescript',
'classProperties',
'optionalChaining',
'nullishCoalescingOperator',
]
: [
'jsx',
['flow', {all: true}],
'classProperties',
'objectRestSpread',
'optionalChaining',
'nullishCoalescingOperator',
],
plugins: isTypeScript ? tsParsePluins : jsParsePlugins,
sourceType: 'module',
});
const transformed = transformFromAstSync(ast, src, {
@@ -83,7 +88,10 @@ export default function transform({
compact: false,
root: options.projectRoot,
filename,
plugins,
plugins: [
...(isTypeScript ? tsTransformPlugins : jsTransformPlugins),
...plugins,
],
presets,
sourceMaps: true,
retainLines: !!flipperEnv.FLIPPER_TEST_RUNNER,