Extract file system interaction from SonarWebSocketImpl
Summary: SonarWebSocketImpl has got pretty bloated. So I'm extracting all the file interaction out of it into ConnectionContextStore. The purpose of this class is to provide all the context needed to establish a connection. This makes SonarWebSocketImpl more functional and therefore testable. Reviewed By: priteshrnandgaonkar Differential Revision: D9540089 fbshipit-source-id: 0cd1d69f2b11eaf9f569245a2da14f85cc140427
This commit is contained in:
committed by
Facebook Github Bot
parent
a5af72a169
commit
afea2f63ec
28
xplat/SonarTestLib/ConnectionContextStoreMock.h
Normal file
28
xplat/SonarTestLib/ConnectionContextStoreMock.h
Normal file
@@ -0,0 +1,28 @@
|
||||
#include <Sonar/ConnectionContextStore.h>
|
||||
|
||||
namespace facebook {
|
||||
namespace sonar {
|
||||
namespace test {
|
||||
|
||||
class ConnectionContextStoreMock : public ConnectionContextStore {
|
||||
public:
|
||||
ConnectionContextStoreMock() : ConnectionContextStore(DeviceData()) {
|
||||
}
|
||||
bool hasRequiredFiles() {
|
||||
return true;
|
||||
}
|
||||
std::string createCertificateSigningRequest() {
|
||||
return "thisIsACsr";
|
||||
}
|
||||
std::shared_ptr<SSLContext> getSSLContext() {
|
||||
return nullptr;
|
||||
}
|
||||
dynamic getConnectionConfig() {
|
||||
return nullptr;
|
||||
}
|
||||
std::string getCertificateDirectoryPath() {
|
||||
return "/something/sonar/";
|
||||
}
|
||||
};
|
||||
|
||||
}}}
|
||||
Reference in New Issue
Block a user