log listener

Summary:
The logs plugin opened a new log connection every time it was activated and never closed the connection.

This is now changed. Once a device is connected, a log connection is opened. The logs plugin subscribes and unsubscribes to this connection. This allows the logs plugin it even access the logs from when it was not activated and ensures to only open on connection to read the logs. Logs are persisted when switching away from the plugin.

Also removes the spinner from the logs plugin, as it loads much faster now.

Reviewed By: jknoxville

Differential Revision: D9613054

fbshipit-source-id: e37ea56c563450e7fc4e3c85a015292be1f2dbfc

src/devices/AndroidDevice.js

@@ -5,7 +5,7 @@
  * @format
  */
 
-import type {DeviceType, DeviceShell, DeviceLogListener} from './BaseDevice.js';
+import type {DeviceType, DeviceShell} from './BaseDevice.js';
 
 import {Priority} from 'adbkit-logcat-fb';
 import child_process from 'child_process';
@@ -25,6 +25,41 @@ export default class AndroidDevice extends BaseDevice {
     if (deviceType == 'physical') {
       this.supportedPlugins.push('DeviceCPU');
     }
+
+    this.adb.openLogcat(this.serial).then(reader => {
+      reader.on('entry', entry => {
+        if (this.logListeners.size > 0) {
+          let type = 'unknown';
+          if (entry.priority === Priority.VERBOSE) {
+            type = 'verbose';
+          }
+          if (entry.priority === Priority.DEBUG) {
+            type = 'debug';
+          }
+          if (entry.priority === Priority.INFO) {
+            type = 'info';
+          }
+          if (entry.priority === Priority.WARN) {
+            type = 'warn';
+          }
+          if (entry.priority === Priority.ERROR) {
+            type = 'error';
+          }
+          if (entry.priority === Priority.FATAL) {
+            type = 'fatal';
+          }
+
+          this.notifyLogListeners({
+            tag: entry.tag,
+            pid: entry.pid,
+            tid: entry.tid,
+            message: entry.message,
+            date: entry.date,
+            type,
+          });
+        }
+      });
+    });
   }
 
   supportedPlugins = [
@@ -43,41 +78,6 @@ export default class AndroidDevice extends BaseDevice {
     return ['date', 'pid', 'tid', 'tag', 'message', 'type', 'time'];
   }
 
-  addLogListener(callback: DeviceLogListener) {
-    this.adb.openLogcat(this.serial).then(reader => {
-      reader.on('entry', async entry => {
-        let type = 'unknown';
-        if (entry.priority === Priority.VERBOSE) {
-          type = 'verbose';
-        }
-        if (entry.priority === Priority.DEBUG) {
-          type = 'debug';
-        }
-        if (entry.priority === Priority.INFO) {
-          type = 'info';
-        }
-        if (entry.priority === Priority.WARN) {
-          type = 'warn';
-        }
-        if (entry.priority === Priority.ERROR) {
-          type = 'error';
-        }
-        if (entry.priority === Priority.FATAL) {
-          type = 'fatal';
-        }
-
-        callback({
-          tag: entry.tag,
-          pid: entry.pid,
-          tid: entry.tid,
-          message: entry.message,
-          date: entry.date,
-          type,
-        });
-      });
-    });
-  }
-
   reverse(): Promise<void> {
     if (this.deviceType === 'physical') {
       return this.adb