log listener

Summary:
The logs plugin opened a new log connection every time it was activated and never closed the connection.

This is now changed. Once a device is connected, a log connection is opened. The logs plugin subscribes and unsubscribes to this connection. This allows the logs plugin it even access the logs from when it was not activated and ensures to only open on connection to read the logs. Logs are persisted when switching away from the plugin.

Also removes the spinner from the logs plugin, as it loads much faster now.

Reviewed By: jknoxville

Differential Revision: D9613054

fbshipit-source-id: e37ea56c563450e7fc4e3c85a015292be1f2dbfc

src/PluginContainer.js

@@ -8,6 +8,7 @@ import type {SonarPlugin, SonarBasePlugin} from './plugin.js';
 import type LogManager from './fb-stubs/Logger';
 import type Client from './Client.js';
 import type BaseDevice from './devices/BaseDevice.js';
+import type {Props as PluginProps} from './plugin';
 
 import {SonarDevicePlugin} from './plugin.js';
 import {
@@ -43,7 +44,9 @@ type Props = {
   selectedDevice: BaseDevice,
   selectedPlugin: ?string,
   selectedApp: ?string,
-  pluginStates: Object,
+  pluginStates: {
+    [pluginKey: string]: Object,
+  },
   clients: Array<Client>,
   setPluginState: (payload: {
     pluginKey: string,
@@ -128,6 +131,15 @@ class PluginContainer extends Component<Props, State> {
       return null;
     }
 
+    const props: PluginProps<Object> = {
+      key: pluginKey,
+      logger: this.props.logger,
+      persistedState: pluginStates[pluginKey] || {},
+      setPersistedState: state => setPluginState({pluginKey, state}),
+      target,
+      ref: this.refChanged,
+    };
+
     return (
       <React.Fragment>
         <Container key="plugin">
@@ -136,14 +148,7 @@ class PluginContainer extends Component<Props, State> {
               activePlugin.title
             }" encountered an error during render`}
             logger={this.props.logger}>
-            {React.createElement(activePlugin, {
-              key: pluginKey,
-              logger: this.props.logger,
-              persistedState: pluginStates[pluginKey] || {},
-              setPersistedState: state => setPluginState({pluginKey, state}),
-              target,
-              ref: this.refChanged,
-            })}
+            {React.createElement(activePlugin, props)}
           </ErrorBoundary>
         </Container>
         <SidebarContainer id="sonarSidebar" />