From afae1bd141406af57fd97934db810ebaa3f600d5 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Thu, 2 Nov 2023 10:42:15 -0700 Subject: [PATCH] Track unable to become ready within timeout Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official. Reviewed By: antonk52 Differential Revision: D50927954 fbshipit-source-id: ff767acdc51b942c6deb92ffbfd93288b3367062 --- desktop/flipper-server-core/src/server/startServer.tsx | 1 + desktop/flipper-server-core/src/tracker.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/desktop/flipper-server-core/src/server/startServer.tsx b/desktop/flipper-server-core/src/server/startServer.tsx index 66bcf1f5f..5b7a4420b 100644 --- a/desktop/flipper-server-core/src/server/startServer.tsx +++ b/desktop/flipper-server-core/src/server/startServer.tsx @@ -110,6 +110,7 @@ export async function startServer( }> { setTimeout(() => { if (!isReady && isProduction()) { + tracker.track('server-ready-timeout', {timeout: timeoutSeconds}); console.error( `[flipper-server] Unable to become ready within ${timeoutSeconds} seconds, exit`, ); diff --git a/desktop/flipper-server-core/src/tracker.tsx b/desktop/flipper-server-core/src/tracker.tsx index e3db6228d..dd5ba2067 100644 --- a/desktop/flipper-server-core/src/tracker.tsx +++ b/desktop/flipper-server-core/src/tracker.tsx @@ -49,6 +49,7 @@ type TrackerEvents = { 'server-socket-already-in-use': {}; 'server-open-ui': {browser: boolean; hasToken: boolean}; 'server-ws-server-error': {port: number; error: string}; + 'server-ready-timeout': {timeout: number}; 'browser-connection-created': { successful: boolean; timeMS: number;