From af5b9532ecfc88eb5b6aeca6cb76526cabf56058 Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Fri, 21 Jul 2023 04:18:02 -0700 Subject: [PATCH] Don't throw on timeouts during client connection. Summary: Timeout exceptions while connection to new clients where rethrown but catched nowhere. Probably this warning should be handled more gracefully, but this at least moves it to warn rather than spawning our monitoring on transient issues Reviewed By: passy, antonk52 Differential Revision: D47665050 fbshipit-source-id: ad51808d12e9f4de318d4426933ecb3787839b7c --- desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx b/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx index 51db4320e..563c0987b 100644 --- a/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx +++ b/desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx @@ -366,7 +366,7 @@ export async function handleClientConnected( ); return; } - throw e; + console.warn(`[conn] Failed to handle client connected: ${e}`); } }