From aeee96c050d8b6a4720007bff6516e1e184ff07b Mon Sep 17 00:00:00 2001 From: Benjamin Elo Date: Mon, 22 Jul 2019 03:03:14 -0700 Subject: [PATCH] Reversed order of incoming nav events Summary: Since events will be displayed in a timeline view with a flex-cloumn, it is more efficient to have the events be added to the event array in reverse order; that is the newest events at the front of the array. Reviewed By: passy Differential Revision: D16379893 fbshipit-source-id: c85a2cca118e2d4ae990f69134f5d5770c360fbd --- src/plugins/navigation/__tests__/testNavigationPlugin.node.js | 2 +- src/plugins/navigation/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/navigation/__tests__/testNavigationPlugin.node.js b/src/plugins/navigation/__tests__/testNavigationPlugin.node.js index bc8130431..1642dd230 100644 --- a/src/plugins/navigation/__tests__/testNavigationPlugin.node.js +++ b/src/plugins/navigation/__tests__/testNavigationPlugin.node.js @@ -74,11 +74,11 @@ test('add incoming nav event to persisted state with nav events', () => { INCOMING_NAV_EVENT, ); expect(newPersistedState.navigationEvents).toEqual([ - ...persistedState.navigationEvents, { uri: 'mock://this_is_a_mock_uri/mock', date: DATE_MOCK_1, }, + ...persistedState.navigationEvents, ]); } else { expect(reducer).not.toBeNull(); diff --git a/src/plugins/navigation/index.js b/src/plugins/navigation/index.js index cee9fef80..13f9d0229 100644 --- a/src/plugins/navigation/index.js +++ b/src/plugins/navigation/index.js @@ -42,11 +42,11 @@ export default class extends FlipperPlugin { return { ...persistedState, navigationEvents: [ - ...persistedState.navigationEvents, { uri: payload.uri === undefined ? null : payload.uri, date: payload.date || new Date(), }, + ...persistedState.navigationEvents, ], }; default: