jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Flipper should not depend on Yoga

Browse Source 
Summary: Flipper should not depend on Yoga, since it already depends on Yogakit. Yogakit itself depends on Yoga anyway. Also, Flipper seems to use Yogakit APIs anyway.

Reviewed By: shergin

Differential Revision: D7185089

fbshipit-source-id: 69f7e030999041be7a007b9ca56c529f8c1ae121
This commit is contained in:
Ram N
2019-09-02 12:48:31 -07:00
committed by Facebook Github Bot
parent f4fc96756a
commit ae8da51e00
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
FlipperKit.podspec
View File

@@ -1,5 +1,4 @@
folly_compiler_flags = '-DDEBUG=1 -DFLIPPER_OSS=1 -DFB_SONARKIT_ENABLED=1 -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_HAVE_LIBGFLAGS=0 -DFOLLY_HAVE_LIBJEMALLOC=0 -DFOLLY_HAVE_PREADV=0 -DFOLLY_HAVE_PWRITEV=0 -DFOLLY_HAVE_TFO=0 -DFOLLY_USE_SYMBOLIZER=0' folly_compiler_flags = '-DDEBUG=1 -DFLIPPER_OSS=1 -DFB_SONARKIT_ENABLED=1 -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_HAVE_LIBGFLAGS=0 -DFOLLY_HAVE_LIBJEMALLOC=0 -DFOLLY_HAVE_PREADV=0 -DFOLLY_HAVE_PWRITEV=0 -DFOLLY_HAVE_TFO=0 -DFOLLY_USE_SYMBOLIZER=0'
yoga_version = '~> 1.14'
yogakit_version = '~> 1.14' yogakit_version = '~> 1.14'
flipperkit_version = '0.23.4' flipperkit_version = '0.23.4'
Pod::Spec.new do |spec| Pod::Spec.new do |spec|
@@ -94,7 +93,6 @@ Pod::Spec.new do |spec|
ss.header_dir = "FlipperKitLayoutPlugin" ss.header_dir = "FlipperKitLayoutPlugin"
ss.dependency 'FlipperKit/Core' ss.dependency 'FlipperKit/Core'
ss.dependency 'FlipperKit/FlipperKitLayoutTextSearchable' ss.dependency 'FlipperKit/FlipperKitLayoutTextSearchable'
ss.dependency 'Yoga', yoga_version
ss.dependency 'YogaKit', yogakit_version ss.dependency 'YogaKit', yogakit_version
ss.compiler_flags = folly_compiler_flags ss.compiler_flags = folly_compiler_flags
ss.public_header_files = 'iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.h', ss.public_header_files = 'iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.h',
@@ -117,7 +115,6 @@ Pod::Spec.new do |spec|
spec.subspec "FlipperKitLayoutComponentKitSupport" do |ss| spec.subspec "FlipperKitLayoutComponentKitSupport" do |ss|
ss.header_dir = "FlipperKitLayoutComponentKitSupport" ss.header_dir = "FlipperKitLayoutComponentKitSupport"
ss.dependency 'FlipperKit/Core' ss.dependency 'FlipperKit/Core'
ss.dependency 'Yoga', yoga_version
ss.dependency 'ComponentKit', '~> 0.0' ss.dependency 'ComponentKit', '~> 0.0'
ss.dependency 'FlipperKit/FlipperKitLayoutPlugin' ss.dependency 'FlipperKit/FlipperKitLayoutPlugin'
ss.dependency 'FlipperKit/FlipperKitLayoutTextSearchable' ss.dependency 'FlipperKit/FlipperKitLayoutTextSearchable'