Refactor plugin lists computations

Summary: This is purely refactoring change. Before that we computed plugin lists in-place in PluginList component. Now we will be re-computing them as side effect and will keep computed lists in redux. This makes it easier to re-use plugin lists in other places outside of PluginList component, e.g. in the upcoming Marketplace UI.

Reviewed By: mweststrate

Differential Revision: D29161719

fbshipit-source-id: 5cb06d4d8a553aa856101c78b2311fbc078c6bd7
This commit is contained in:
Anton Nikolaev
2021-06-17 07:38:51 -07:00
committed by Facebook GitHub Bot
parent 0d6262aa5e
commit ac9ef7620a
10 changed files with 325 additions and 190 deletions

View File

@@ -64,6 +64,10 @@ import usageTracking, {
Action as TrackingAction,
State as TrackingState,
} from './usageTracking';
import pluginLists, {
State as PluginListsState,
Action as PluginListsAction,
} from './pluginLists';
import user, {State as UserState, Action as UserAction} from './user';
import JsonFileStorage from '../utils/jsonFileReduxPersistStorage';
import LauncherSettingsStorage from '../utils/launcherSettingsStorage';
@@ -93,6 +97,7 @@ export type Actions =
| HealthcheckAction
| TrackingAction
| PluginDownloadsAction
| PluginListsAction
| {type: 'INIT'};
export type State = {
@@ -110,6 +115,7 @@ export type State = {
healthchecks: HealthcheckState & PersistPartial;
usageTracking: TrackingState;
pluginDownloads: PluginDownloadsState;
pluginLists: PluginListsState;
};
export type Store = ReduxStore<State, Actions>;
@@ -211,4 +217,5 @@ export default combineReducers<State, Actions>({
),
usageTracking,
pluginDownloads,
pluginLists,
});