From ab6fe68a700254b443522ce5f7a14219762cbcaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20B=C3=BCchele?= <danielbuechele@fb.com>
Date: Fri, 21 Jun 2019 05:54:11 -0700
Subject: [PATCH] show multiple lines of markers

Summary: Multiple markers might got truncated, now the list expands on hover

Reviewed By: jknoxville

Differential Revision: D15939404

fbshipit-source-id: 2640f200dc17876391e04eeced59bc7a2d925113
---
 src/ui/components/MarkerTimeline.js | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/ui/components/MarkerTimeline.js b/src/ui/components/MarkerTimeline.js
index d5370453f..d03c81218 100644
--- a/src/ui/components/MarkerTimeline.js
+++ b/src/ui/components/MarkerTimeline.js
@@ -48,9 +48,15 @@ const Point = styled(FlexRow)(props => ({
   right: 10,
   cursor: props.onClick ? 'pointer' : 'default',
   borderRadius: 3,
-  alignItems: 'center',
+  alignItems: 'flex-start',
+  lineHeight: '16px',
   ':hover': {
-    background: props.onClick ? colors.light02 : 'transparent',
+    background: `linear-gradient(to top, rgba(255,255,255,0) 0, #ffffff 10px)`,
+    paddingBottom: 5,
+    zIndex: 2,
+    '> span': {
+      whiteSpace: 'initial',
+    },
   },
   '::before': {
     position: 'relative',
@@ -68,6 +74,7 @@ const Point = styled(FlexRow)(props => ({
     border: '1px solid rgba(0,0,0,0.2)',
     backgroundColor: props.threadColor,
     marginRight: 6,
+    zIndex: 3,
     boxShadow: props.selected
       ? `0 0 0 2px ${colors.macOSTitleBarIconSelected}`
       : null,
@@ -90,11 +97,13 @@ const Time = styled('span')({
   color: colors.light30,
   fontWeight: '300',
   marginRight: 4,
+  marginTop: -2,
 });
 
 const Code = styled(Text)({
   overflow: 'hidden',
   textOverflow: 'ellipsis',
+  marginTop: -1,
 });
 
 type TimePoint = {
@@ -194,7 +203,6 @@ export default class MarkerTimeline extends Component<Props, State> {
               key={i}
               threadColor={p.color}
               cut={p.isCut}
-              title={p.markerNames.length > 1 ? p.markerNames.join(', ') : null}
               positionY={p.positionY}
               onClick={onClick ? () => onClick(p.markerKeys) : undefined}
               selected={p.markerKeys.includes(this.props.selected)}